Skip to content

Conversation

@BorisDog
Copy link
Collaborator

No description provided.

@BorisDog BorisDog requested a review from JamesKovacs February 15, 2023 01:45
@JamesKovacs JamesKovacs requested review from DmitryLukyanov and removed request for JamesKovacs February 15, 2023 17:08
public BuildersMQLAttribute(string message, string version, params int[] codeLines) :
base(DiagnosticRulesConstants.Builders2MQL,
message,
locations: codeLines.Any() ? codeLines.Select(l => new Location(l, -1)).ToArray() : null,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically codelines can be null in this case: BuildersMQLAttribute("", "", null).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, done!

Copy link

@DmitryLukyanov DmitryLukyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See a comment and then LGTM

@BorisDog BorisDog changed the title VS-83: Add Atlas Search basic builders support VS-85: Add Atlas Search basic builders support Feb 15, 2023
@BorisDog BorisDog merged commit 36545e1 into mongodb:main Feb 15, 2023
@BorisDog BorisDog deleted the vs85 branch February 15, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants