CDRIVER-3823 ignore SIGPIPE on osx #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
approved these changes
Jan 7, 2021
Contributor
kmahar
left a comment
kmahar
left a comment
There was a problem hiding this comment.
this fixes the crash! thanks for fixing this, should make our macOS Evergreen tests a lot more reliable 🙂
kevinAlbs
approved these changes
Jan 7, 2021
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
Awesome, nice investigative work! I'm surprised we hadn't hit this before.
And I agree that this is better as a socket option instead of process-wide, so we do not interfere with existing signal handlers.
Co-authored-by: Kevin Albertson <[email protected]>
kevinAlbs
pushed a commit
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSG_NOSIGNAL, the flag that we currently use to ignoreSIGPIPEon POSIX systems, is not supported on OSX. Instead, OSX offers theSO_NOSIGPIPEflag that can be set as a socket option before performing writes.I had asked @kmahar to test a different solution for ignoring
SIGPIPE:signal(SIGPIPE, SIG_IGN);Upon further research, this solution isn't ideal, because it ignores
SIGPIPEfor the entire program, including any user code running a level above the C driver. In the case that a user is interested inSIGPIPEfor some reason, setting the handler toSIG_IGNlike this would also captureSIGPIPEin user code. TheSO_NOSIGPIPEsolution is less intrusive for a library like ours.