-
Notifications
You must be signed in to change notification settings - Fork 456
Update Earthfile to use uvx cmake #2083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
aafb306
Suppress -Wpoison-system-directories for Apple Clang
eramongodb 4fb5655
Update Earthfile to use `uvx cmake`
eramongodb 9245c86
Remove duplicate envkey
eramongodb 9079727
Merge remote-tracking branch 'upstream/master' into cdriver-earthly
eramongodb 10d88e9
Merge remote-tracking branch 'upstream/master' into cdriver-earthly
eramongodb 9a486f9
Merge remote-tracking branch 'upstream/master' into cdriver-earthly
eramongodb 5606c37
Merge remote-tracking branch 'upstream/master' into cdriver-earthly
eramongodb 9e8be76
Install uv to /opt/bin/uv instead of .local/bin with pipx
eramongodb 5772c96
Add Earthly coverage for AlmaLinux 8, 9, and 10
eramongodb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following Red Hat's (wildly unpopular) decision to kill CentOS, Rocky Linux and AlmaLinux were created to take up the mantle as "drop-in-replacements" for RHEL. It may be better to switch to Rocky or Alma rather than use CentOS Steram as stand-ins RHEL 9+. Rocky and Alma are also available in
docker.io, allowing us to continue to use ECR.(RedHat killing CentOS is also the reason why CentOS 8 EOL is earlier then 7: They kicked the project to the curb at version 8 and didn't want to support it any more).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This isn't a blocking request for changes, just an alternative to consider.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep CentOS Stream coverage for official Red Hat LTS compatibility coverage, but I'm fine with extending coverage to AlmaLinux as well, which cursory research suggests may have better community activity and support than Rocky Linux. Some additional context included below for reference.
Since AlmaLinux is meant to (almost) mirror CentOS Stream, a common
CENTOS_STREAM_ENVis used to define bothenv.centos*andenv.almalinux*.Per Red Hat:
Per AlmaLinux:
Per Rocky Linux: