Migrate to newer Power, zSeries, and MacOS distros #1791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Nov 18, 2024
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
LGTM with suggestion.
Comment on lines
25
to
28
| ('macos-14', 'clang', None, 'cyrus', ['auth'], ['server', 'replica' ], ['4.2', '4.4', '5.0']), | ||
|
|
||
| ('macos-11-arm64', 'clang', None, 'cyrus', ['auth'], ['server', 'replica' ], ['6.0']), | ||
| ('macos-14-arm64', 'clang', None, 'cyrus', ['auth'], ['server', 'replica' ], ['6.0']), |
Collaborator
There was a problem hiding this comment.
Suggested change
| ('macos-14', 'clang', None, 'cyrus', ['auth'], ['server', 'replica' ], ['4.2', '4.4', '5.0']), | |
| ('macos-11-arm64', 'clang', None, 'cyrus', ['auth'], ['server', 'replica' ], ['6.0']), | |
| ('macos-14-arm64', 'clang', None, 'cyrus', ['auth'], ['server', 'replica' ], ['6.0']), | |
| ('macos-14', 'clang', None, 'cyrus', ['auth'], ['server'], ['4.2', '4.4', '5.0']), | |
| ('macos-11-arm64', 'clang', None, 'cyrus', ['auth'], ['server'], ['6.0']), | |
| ('macos-14-arm64', 'clang', None, 'cyrus', ['auth'], ['server'], ['6.0']), |
Suggest removing replica for <7.0 server tests to reduce macOS testing. The openssl and winssl CSE tasks similarly test only server for <7.0 server. I expect testing only server for <7.0 was originally intended (given the comment # Test 7.0+ with a replica set).
This was referenced Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by DEVPROD-21, DEVPROD-40, and DEVPROD-5083. Verified by this patch (which excludes Earthly tasks which are currently failing due to DockerHub rate limits).
See distro usage guidelines for MacOS, Power, and zSeries.
Note
Changed generic references to Power8/Power9/PowerPC/powerpc64le/etc. to simply "Power" as it is not clear which specific Power-related architecture is being provided by a given Evergreen distro. (It's probably Power8, but nevertheless.)
scan-buildis not available), so it remains onmacos-14for now.macos-11-arm64distro from the Darwin matrices if testing on both MacOS 11 (EOL) and MacOS 14 is considered redundant.