CDRIVER-5487 use aligned alloc for bson_array_builder_t #1544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catched with UBSAN:
runtime error: member access within misaligned address 0x51100000a040 for type 'bson_array_builder_t' (aka 'struct _bson_array_builder_t'), which requires 128 byte alignment
0x51100000a040: note: pointer points here
01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
^
#0 0x5bb2a5c5b759 in bson_array_builder_new [...]/mongo-c-driver/src/src/libbson/src/bson/bson.c:3662:21
#1 0x5bb2a5c65a43 in bson_append_array_builder_begin [...]/mongo-c-driver/src/src/libbson/src/bson/bson.c:3983:13
Signed-off-by: Louis Solofrizzo <[email protected]>
kevinAlbs
requested changes
Feb 26, 2024
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
Hello @Ne02ptzero thank you for the contribution. Included a suggested change.
Co-authored-by: Kevin Albertson <[email protected]>
kevinAlbs
changed the title
kevinAlbs
approved these changes
Feb 26, 2024
kevinAlbs
added a commit
that referenced
this pull request
Feb 26, 2024
Signed-off-by: Louis Solofrizzo <[email protected]> Co-authored-by: Kevin Albertson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catched with UBSAN: