CDRIVER-4673 fix build of libmongoc using system libbson #1387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
bson-dsl.htosrc/common.mongo::detail::c_platformif using system libbson.Background & Motivation
This PR resolves two observed issues when building libmongoc using a system install of libbson.
On the
r1.24branch, a compile error referenced in CDRIVER-4673 occurs:fatal error: 'bson/bson-dsl.h' file not found.bson-dsl.his not installed with libbson, butbson-dsl.his needed to compile libmongoc. 16d6237 movesbson-dsl.htosrc/common. This is applied to r1.24 in #1388On
master, there is an additional error reported in cmake. Running./.evergreen/scripts/install-libmongoc-after-libbson.shresults in:8883017 will not define
c_platformif using a system libbson install to fix this error.