MONGOCRYPT-737 set status if mongocrypt_kms_ctx_fail
called with retry disabled
#908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to 7aeaec4. Calling
mongocrypt_kms_ctx_fail
with retry disabled is expected to result in an error.An early return in
mongocrypt_kms_ctx_fail
returnsfalse
to indicate error, but does not set the status:This PR removes the
!kms->retry_enabled
condition to fall through to the intended error check below: