Implement Builder::toSql using JSON representation of the MQL
#2931
Conversation
| @@ -1535,4 +1546,10 @@ public function orWhereIntegerNotInRaw($column, $values, $boolean = 'and') | |||
| { | |||
| throw new BadMethodCallException('This method is not supported by MongoDB'); | |||
| } | |||
|
|
|||
| /** @internal This method is not supported by MongoDB. */ | |||
| public function insertUsing(array $columns, $query) | |||
There was a problem hiding this comment.
We relied on the exception thrown by the parent method that uses toSql.
| * Return the JSON representation of the MongoDB Query. | ||
| * Naming is inherited and used for compatibility with third-party packages. | ||
| * | ||
| * @internal |
There was a problem hiding this comment.
Should this still be @internal?
I don't have enough context to understand how/why rappasoft/laravel-livewire-tables needs to support MongoDB, but isn't there some concern that returning JSON strings here might break other packages that expect these methods to return actual SQL statements?
My thinking is that packages wishing to support this library should be the ones to change and conditionally call toMql().
There was a problem hiding this comment.
It's used for debugging: https://tables.laravel-boilerplate.com/tailwind
But Laravel Debugbar would provide the same information.
And I agree this can lead to other problems if packages expect SQL and use the returned value as such.
Fix #2797
The method
toSqlis used by third party packages likerappasoft/laravel-liveware-tables.Checklist