Skip to content

Add config for codacy #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add config for codacy #1944

wants to merge 2 commits into from

Conversation

@Smolevich
Copy link
Contributor

@Smolevich Smolevich commented Feb 5, 2020

  • Added .codacy.yml

@Smolevich
Copy link
Contributor Author

Smolevich commented Feb 5, 2020

@rennokki @divine @Giacomo92 @jenssegers review please

@Smolevich
Copy link
Contributor Author

Smolevich commented Feb 5, 2020

Button Merge pull request is blocked because At least 1 approving review is required by reviewers with write access , @jenssegers can you add someone from @divine ,@rennokki, @Giacomo92 to members for repo?

brandon-braner
brandon-braner reviewed Feb 6, 2020
View reviewed changes
Copy link

@brandon-braner brandon-braner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Codacy something we are looking at adding to this repo?

@divine
Copy link
Contributor

divine commented Feb 6, 2020

Is Codacy something we are looking at adding to this repo?

Hi,

Codacy has been added already and this PR just adds an ignore rule for folder .github so this PR #1943 will be passing.

@jenssegers any update?

Thanks.

@Smolevich
Copy link
Contributor Author

Smolevich commented Feb 7, 2020

Is Codacy something we are looking at adding to this repo?

Снимок экрана 2020-02-07 в 7 32 07

@Smolevich
Copy link
Contributor Author

Smolevich commented Feb 8, 2020

@divine can you do this PR in another PR and i accept him?

@Giacomo92
Copy link

Giacomo92 commented Feb 8, 2020

I can do also this! @Smolevich

@Smolevich Smolevich mentioned this pull request Feb 8, 2020
Merged
@Giacomo92 Giacomo92 mentioned this pull request Feb 8, 2020
Merged
@Smolevich Smolevich closed this Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@brandon-braner brandon-braner brandon-braner left review comments

@Giacomo92 Giacomo92 Giacomo92 approved these changes

@divine divine divine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Smolevich @divine @Giacomo92 @brandon-braner