EmbedsMany respect primaryKey on association #1740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone please review this simple PR so it can get merged? Thanks. |
jenssegers
reviewed
Sep 3, 2019
|
Looks good, would just replace the |
|
Thanks, I will update the PR. |
Co-Authored-By: Jens Segers <[email protected]>
|
Sorry, I'm fairly new to GitHub PRs and didn't realize I could just accept your suggestion. Done. |
|
Thank you for merging! |
This was referenced Feb 15, 2020
mnphpexpert
added a commit
to mnphpexpert/laravel-mongodb
that referenced
this pull request
Sep 2, 2024
EmbedsMany respect primaryKey on association
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1749
I have a situation where I don't want my EmbedsMany objects to have an _id attribute. Normally I can just set the $primaryKey = null on my object. But EmbedsMany is not respecting this on new associations. This change fixes that.