Fix issue with chunkById. #1317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jenssegers Would you mind reviewing this when you have a chance? Thanks! |
mnphpexpert
added a commit
to mnphpexpert/laravel-mongodb
that referenced
this pull request
Sep 2, 2024
Fix issue with chunkById.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
chunkByIdmethod doesn't work with MongoDB, because the framework assumes that the ID will be numeric & doesn't provide an easy way for the user to override that at runtime. I was able to fix this by overriding theforPageAfterIdmethod so that it would convert Laravel's assumed "zero" ID into an equivalent "zero" ObjectId.I've also added a test to demonstrate the bug & fix.