Skip to content

feat(NODE-4789): support Map stringification in EJSON #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 16, 2023
Merged

feat(NODE-4789): support Map stringification in EJSON #567

merged 5 commits into from
Mar 16, 2023

Conversation

@W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Mar 14, 2023 •
edited
Loading

Description

What is changing?

Allow for Maps to be stringified using EJSON.stringify

Is there new documentation needed for these changes?

No

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James changed the title fix(NODE-4789): Add fix feat(NODE-4789): Support Map Stringification in EJSON Mar 14, 2023
@W-A-James W-A-James marked this pull request as ready for review March 14, 2023 21:09
addaleax
addaleax reviewed Mar 14, 2023
View reviewed changes
@W-A-James @addaleax
Update src/extended_json.ts
c5e6cf5 
Co-authored-by: Anna Henningsen <[email protected]>
@nbbeeken nbbeeken self-assigned this Mar 15, 2023
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 15, 2023
nbbeeken
nbbeeken suggested changes Mar 15, 2023
View reviewed changes
@W-A-James W-A-James requested a review from nbbeeken March 15, 2023 20:47
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Mar 15, 2023
@nbbeeken nbbeeken changed the title feat(NODE-4789): Support Map Stringification in EJSON feat(NODE-4789): support Map stringification in EJSON Mar 16, 2023
@nbbeeken nbbeeken merged commit c70c82d into main Mar 16, 2023
@nbbeeken nbbeeken deleted the NODE-4789/Support_Map_Stringification_in_EJSON branch March 16, 2023 16:08
@github-actions github-actions bot mentioned this pull request May 7, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jun 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax left review comments

@baileympearson baileympearson baileympearson approved these changes

+1 more reviewer

@nbbeeken nbbeeken nbbeeken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nbbeeken nbbeeken

Labels

Team Review Needs review from team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@W-A-James @addaleax @nbbeeken @baileympearson