-
Notifications
You must be signed in to change notification settings - Fork 1.7k
DOCS-1395 config server tutorials #865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -1,246 +1,25 @@ | |||
.. index:: config servers; operations | |||
.. _sharding-procedure-config-server: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing this line might make a link somewhere fail to resolve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I grepped that, and there were no refs linking to sharding-procedure-config-server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet!
I think each of the new documents should have some link to the the conceptual information about config servers and sharded clusters, as they feel a bit abrupt at the moment. |
I'm not sure I correctly updated the redirect. I added the following to /bin/htaccess.yaml: redirect-path: '/administration/sharded-clusters' |
type: 'redirect' | ||
code: 301 | ||
outputs: | ||
- 'v2.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for remembering this, we definitely need to manage the redirect, however:
-
the
redirect-path
field is "take this path and redirect requests for it somewhere else." whileurl-base
is the "somewhere else". So this is basically backwards. No big deal, I have to look at the header each time and repeat the "redirect-path
is fromurl-base
is to" mantra in my head while writing these rules. -
outputs
is the editions/versions of the manual where the redirect must exist. In the following regexp-ish statement, it's everything between the parenshttp://docs.mongodb.org/(manual|master|v2.2|...)/.*
Think about the history of this page: the goal is to make sure that if we've publishedredirect-path
for a given output, that we list it here. In this case I think we wantmanual
andmaster
.Redirects that don't include manual and master are typically for pages that we've added to the current release, and these redirects support the version flipper experience.
Incidentally there are also fake outputs for
before-<version>
andafter-<version>
. which make it possible to specify groups of outputs more easily, and while we don't use many of them right now because we have a limited number of versions, we will have more in the future.
merged! |
* DOCSP-20266: Update Time Series limitations with Data API info * DOCSP-20266: reverting commit * DOCSP-20266: Add Data API the the time series limitations page * DOCSP-20266 * DOCSP-20266:Fix link typo. * DOCSP-20266:Fix link typo. * DOCSP-20266: Incorporate review comments * DOCSP-20266: Upate with review feedback. * DOCSP-20266: Minor edit Co-authored-by: Sarah Olson <[email protected]> Co-authored-by: Sarah Olson <[email protected]> Co-authored-by: Sarah Olson <[email protected]> Co-authored-by: Sarah Olson <[email protected]>
* DOCSP-46527 -- Add GitHub access requirement note * DOCSP-46527 -- copy review revision (cherry picked from commit 8ef53b8)
Ready for merge after Sam reviews