-
Notifications
You must be signed in to change notification settings - Fork 1.7k
DOCS-1377 document missing isMaster fields #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
epc
commented
Apr 11, 2013
- added missing fields to isMaster.txt
- minor rewrite in db.isMaster()
- added term passive to glossary
configuration, or a standalone :program:`mongod`. | ||
|
||
This field will only be ``false`` if the instance is a | ||
:term:`secondary` member of a replica set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is not true. arbiter also return false.
anden(mongod-2.5.0-pre-)[ARBITER/REPLICASET] test> db.isMaster()
{
"setName": "REPLICASET",
"ismaster": false,
"secondary": false,
"hosts": [
"anden.local:30203",
"anden.local:30201",
"anden.local:30200"
],
"passives": [
"anden.local:30202"
],
"arbiters": [
"anden.local:30204"
],
"primary": "anden.local:30200",
"arbiterOnly": true,
"me": "anden.local:30204",
"maxBsonObjectSize": 16777216,
"maxMessageSizeBytes": 48000000,
"localTime": ISODate("2013-04-11T12:49:47.520-0700"),
"ok": 1
}
Aside from the inline comments on the patch, LGTM! :) |
Think this is good to go pending @tychoish comments on the sub-heading style for the different output formats. |
merged! |
* DOCSP-21491 bumping version in snooty.toml * add latest_major_version constant * add latest-lts-version to snooty.toml, replace version constant where applicable * space * conf.py * ltsversion * update * up * source contstant update * fact-rapid-release-install update version
This reverts commit 14910f2.
This reverts commit 14910f2.
* Adding content * Fixing build * Build issues * Third attempt * fixing build * Hope this fixed the build * sigh * sigh * Fixed the error -- thank you John W * Continuing to fix the build for a diff error * Removing unneeded nested TOC * warnings now * Fixing the TOC now * Edits, moving files around in the filesystem * Address tech review * Address copy review
* Adding content * Fixing build * Build issues * Third attempt * fixing build * Hope this fixed the build * sigh * sigh * Fixed the error -- thank you John W * Continuing to fix the build for a diff error * Removing unneeded nested TOC * warnings now * Fixing the TOC now * Edits, moving files around in the filesystem * Address tech review * Address copy review