Skip to content

Fix KeyVaultDb connection #6211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix KeyVaultDb connection #6211

wants to merge 1 commit into from

Conversation

ulascansenturk
Copy link

@ulascansenturk ulascansenturk commented Jun 23, 2022

STAGING

JIRA

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

@biniona-mongodb
Copy link
Contributor

Thanks for the contribution @ulascansenturk! Great catch, looks like we were only defining the keyVaultDb variable in a testing configuration of our sample application. Thanks for the contribution, we will fix this in the other variants (AWS, GCP, and Azure KMS providers) of the Node.js Queryable Encryption sample application shortly.

Appreciate your help 🚀 !

@biniona-mongodb
Copy link
Contributor

biniona-mongodb commented Jun 28, 2022

Looks like a similar update was made in this commit by one of the maintainers of this documentation. Unfortunately, we may not be able to merge this PR due to the conflict. We plan to close this PR without merging. Regardless, we appreciate your effort in improving the documentation and your interest in MongoDB and Queryable Encryption.

Thank you for the help, Alek

mongo-cr-bot pushed a commit that referenced this pull request Feb 5, 2024
* DOCSP-36171-reshard-update

* DOCSP-36171-reshard-update

---------

Co-authored-by: jason-price-mongodb <[email protected]>
mongo-cr-bot pushed a commit that referenced this pull request Feb 5, 2024
* DOCSP-36171-reshard-update

* DOCSP-36171-reshard-update

---------

Co-authored-by: jason-price-mongodb <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants