DOCSP-13855-mod-has-inconsistent-rounding

[ianf-mongodb]

No description provided.

[jeff-allen-mongo]

[typo]

This should be "The following examples demonstrate..."

We also have an extra space between behavior and the colon.

[jeff-allen-mongo]

These examples are good, but this is not the most helpful format for users. Since this entire code block is copyable, users will expect to be able to copy and paste this block into their shell and have it run successfully. However, by including the input and output in the same code block, we run into issues.

One approach we could consider:

Place the input code block, followed by output code block, and label each code block accordingly. For example:

Input query:

.. code-block:: javascript

   db.inventory.find( { qty: { $mod: [ 4.0, 0 ] } } )

Results:

   .. code-block:: javascript
      :copyable: false
      
      { _id: 1, item: 'abc123', qty: 0 }
      { _id: 3, item: 'ijk123', qty: 12 }

And repeat this structure for each example.

[jeff-allen-mongo]

Since "4" is referring to a value in the code, we should monospace it:

``4``

[jeff-allen-mongo]

We should refer to this expression as $mod (not Modulo). As currently written, it's reading like we're introducing a new concept because up until now, we've been referring to this expression exclusively as $mod.

[jeff-allen-mongo]

This sentence was a little unclear to me and reads like it might be missing a comma. Consider something like:

Each of the example queries apply ``4`` to the mod function regardless of decimal points, and result in the same output.

[jeff-allen-mongo]

Should we remove the word "down"? If I have a negative number, rounding toward zero would be rounding up, not rounding down.

[jeff-allen-mongo]

In the previous review, Nikita suggested changing this section title to "Floating Point Arguments". Did we want to incorporate that suggestion?