Skip to content

DOCS-15883 update left-nav for mongo mongosh #5351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2021
Merged

DOCS-15883 update left-nav for mongo mongosh #5351

merged 1 commit into from
May 14, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 12, 2021

This ticket:

  • replaces mongo shell with a link to the new mongosh in the left nav
  • moves the old mongo link to Reference section
  • renames the link to 'Legacy mongo Shell'
  • returns a TOC to the legacy page that had been dropped

Most of the updated files are included because of path updates in links to the old mongo shell.

source/reference/mongo.txt is a stripped down version of the older source/mongo.txt landing page

The other changes are to link up the indices and TOCs properly.

JIRA

https://jira.mongodb.org/browse/DOCSP-15883

STAGING

Main landing page

https://docs-mongodbcom-staging.corp.mongodb.com/docs/docsworker-xlarge/DOCSP-15883-left-nav-updates-for-mongo-mongosh-v5.0/

Legacy mongo shell pages

https://docs-mongodbcom-staging.corp.mongodb.com/docs/docsworker-xlarge/DOCSP-15883-left-nav-updates-for-mongo-mongosh-v5.0/reference/mongo/

@ghost ghost requested a review from mmarcon May 12, 2021 19:00
Copy link
Collaborator

@mmarcon mmarcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If possible, I'd make that minor tweak I suggested.

@@ -35,7 +34,7 @@ project, this Manual and additional editions of this text.

Introduction </introduction>
Installation </installation>
/mongo
MongoDB Shell (mongosh) <https://docs.mongodb.com/mongodb-shell/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Can we use a monospaced font for mongosh here to be consistent with how it's displayed in References?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The top level entry is a link to a page in another repo. Unfortunately we can't use markup. The link in the References section picks up its formatting from a page within the docs repo so we can modify it there.

It's a little inconsistent, but rather than remove the formatting from References to match the top-level entry, I'm going to leave refernce/mongosh in monospace since that keeps the copy on the linked page consistent with usage elsewhere in the docs.

Let me know if we should try to find a different resolution

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@jeff-allen-mongo jeff-allen-mongo merged commit 54ff22f into mongodb:v5.0 May 14, 2021
mongo-cr-bot pushed a commit that referenced this pull request Nov 29, 2023
* DOCSP-31755 adding note about firewall

* DOCSP-31755 adding note about firewall

* DOCSP-31755 copy edit

* DOCSP-31755 tech edit

* DOCSP-31755 tech edit
mongo-cr-bot pushed a commit that referenced this pull request Nov 30, 2023
* DOCSP-31755 adding note about firewall

* DOCSP-31755 adding note about firewall

* DOCSP-31755 copy edit

* DOCSP-31755 tech edit

* DOCSP-31755 tech edit
mongo-cr-bot pushed a commit that referenced this pull request Nov 30, 2023
* DOCSP-31755 adding note about firewall

* DOCSP-31755 adding note about firewall

* DOCSP-31755 copy edit

* DOCSP-31755 tech edit

* DOCSP-31755 tech edit
mongo-cr-bot pushed a commit that referenced this pull request Nov 30, 2023
* DOCSP-31755 adding note about firewall

* DOCSP-31755 adding note about firewall

* DOCSP-31755 copy edit

* DOCSP-31755 tech edit

* DOCSP-31755 tech edit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants