Skip to content

DOCSP-15489 update mongo shell banner for mongosh #5280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2021
Merged

DOCSP-15489 update mongo shell banner for mongosh #5280

merged 1 commit into from
May 3, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 30, 2021

There are a large number of files in this change set. Most of them have only superficial changes. Here is a short summary of the changes made:

The substantive changes are found in the following files:
source/includes/fact-mongosh-shell-method.rst
source/includes/fact-mongosh-shell-method-toc.rst

Two index pages had updates:
source/reference/method/js-collection.txt
source/reference/method/js-cursor.txt

One method was only partially migrated to mongosh
source/reference/method/db.getMongo.txt

There was a small, title change in:
source/reference/method.txt

The remaining files in the change set were updated to reflect filenames for the include files.
source/includes/fact-mongo-shell-method.rst was renamed:
source/includes/fact-mongosh-shell-method.rst

source/includes/fact-mongo-shell-method-toc.rst was renamed:
source/includes/fact-mongosh-shell-method-toc.rst

STAGING LINKS

This is a sample page using the updated banner

https://docs-mongodbcom-staging.corp.mongodb.com/docs/docsworker-xlarge/DOCSP-15489-update-mongo-shell-banner-for-mongosh-v5.0/reference/method/db.collection.distinct/

These pages use the updated index files:

https://docs-mongodbcom-staging.corp.mongodb.com/docs/docsworker-xlarge/DOCSP-15489-update-mongo-shell-banner-for-mongosh-v5.0/reference/method/js-cursor/
https://docs-mongodbcom-staging.corp.mongodb.com/docs/docsworker-xlarge/DOCSP-15489-update-mongo-shell-banner-for-mongosh-v5.0/reference/method/js-collection/

This page references a method which was not ported to mongosh

https://docs-mongodbcom-staging.corp.mongodb.com/docs/docsworker-xlarge/DOCSP-15489-update-mongo-shell-banner-for-mongosh-v5.0/reference/method/db.getMongo/

JIRA TICKET LINK

https://jira.mongodb.org/browse/DOCSP-15489

For legacy :binary:`~bin.mongo` shell documention, refer to the
documentation for the corresponding ``MongoDB`` release.

- :v4.4:`mongo shell v4.4 </mongo>`
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: This link is not yet live so it doesn't appear on the staging page. The link will be updated before the docs are released.

For legacy :binary:`~bin.mongo` shell documention, refer to the
documentation for the corresponding ``MongoDB`` release.

- :v4.4:`mongo shell v4.4 </mongo>`
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: This link is not yet live so it doesn't appear on the staging page. The link will be updated before the docs are released.

@mmarcon
Copy link
Collaborator

mmarcon commented Apr 30, 2021

There is a difference in Cursor.map() between mongo and mongosh. In mongo, that method returns an array. However, in mongosh that method returns the Cursor object again. If you need the array you have to call cursor.map().toArray().

@ghost
Copy link
Author

ghost commented Apr 30, 2021

@mmarcon Created https://jira.mongodb.org/browse/DOCSP-15895 for the cursor.map() update

For legacy :binary:`~bin.mongo` shell documention, refer to the
documentation for the corresponding ``MongoDB`` release.

- :v4.4:`mongo shell v4.4 </mongo>`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bulleted list should not be indented like this. It will show an "unexpected indentation" error in the build log.

@jeff-allen-mongo jeff-allen-mongo merged commit 38ca35f into mongodb:v5.0 May 3, 2021
mongo-cr-bot pushed a commit that referenced this pull request Nov 13, 2023
* DOCSP-27629 warning about indexes with collation size

* DOCSP-27629 fixing format

* DOCSP-27629 small fix

* DOCSP-27629 changing note to warning

* DOCSP-27629 tech edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants