Skip to content

(DOCS-11858): filter + nameOnly in listCollections dbcommand #3369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2018

Conversation

nlarew
Copy link
Contributor

@nlarew nlarew commented Jul 6, 2018

@nlarew nlarew requested a review from schmalliso July 6, 2018 19:12
Copy link
Contributor

@schmalliso schmalliso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % a wording quibble.


The default value is ``false``.

.. note::

If ``nameOnly`` is enabled, your ``filter`` expression can only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe switch "if… is enabled" to "when… is true"?

Copy link
Member

@milkie milkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is okay, although it would also be acceptable to say that only the collection names and types are available for filtering. There could be existing users that are filtering on "type" and may be annoyed that we are documenting against something that works today.

@nlarew
Copy link
Contributor Author

nlarew commented Jul 6, 2018

Updated per @milkie's suggestion

Copy link
Member

@milkie milkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nlarew nlarew merged commit fc6eb99 into mongodb:master Jul 6, 2018
mongo-cr-bot pushed a commit that referenced this pull request Jun 20, 2023
* (DOCSP-29546): db.createSearchIndex method (#3140)

* (DOCSP-29546): db.createSearchIndex method

* fix build errors

* add sub-page for mongosh methods

* fix build errors

* change page title

* add wrapper info

* add landing page in snooty.toml

* typo

* edits

* wording

* simplify layout

* tweak example intro

* remove quotes in field names

* address review comments

* single-source table intro

* tweak intro

* fix formatting

* remove accidentally added file (#3290)

* (DOCSP-29548): db.collection.updateSearchIndex method (#3292)

* (DOCSP-29548): db.collection.updateSearchIndex method

* add method descriptions to tables

* add new method page to toc

* fix release note wording

* first pass at replacements

* fix replacements

* more replacements

* replacement for drop

* make example runnable

* update replacements

* fix example

* (DOCSP-29549): dropSearchIndex mongosh method (#3307)

* (DOCSP-29549): dropSearchIndex mongosh method

* standardize collections in examples

* (DOCSP-29881): Add Atlas Search db command outputs (#3139) (#3360)

* (DOCSP-29881): Add Atlas Search db command outputs

* wording

* wording

* typo

* wording

* change admonition language to point to listSearchIndexes

* fix stage name

* adjust language for updateSearchIndex response

* edits

* DOCSP-29552: db.collection.getSearchIndexes method page (#3369)

* WIP

* update toc

* final first draft

* fix build errors

* fix replacement

* fix replacement

* fix replacement

* wording

* remove periods

* wording

* typo

* add link

* add missing replacement

* address review comments

* fix build error

* fix build error

* typo

* single source create access control

* fix typo

* single source access control sections

* add name option

* typo

* wording

* wording

* fix section titles

* standardize casing

* DOCSP-29544: $listSearchIndexes aggregation stage (#3382)

* WIP

* WIP

* change file name

* first draft

* add missing ref

* add learn more

* fixups

* fix id type

* remove extra file

* fix id mismatch

* edit

* fix section title

* add lead-in to example subsections

* edits to BUILDING description per Evan

* adjust table widths
mongo-cr-bot pushed a commit that referenced this pull request Dec 7, 2023
* DOCSP-27853: Atlas search mongosh methods (#3390)

* (DOCSP-29546): db.createSearchIndex method (#3140)

* (DOCSP-29546): db.createSearchIndex method

* fix build errors

* add sub-page for mongosh methods

* fix build errors

* change page title

* add wrapper info

* add landing page in snooty.toml

* typo

* edits

* wording

* simplify layout

* tweak example intro

* remove quotes in field names

* address review comments

* single-source table intro

* tweak intro

* fix formatting

* remove accidentally added file (#3290)

* (DOCSP-29548): db.collection.updateSearchIndex method (#3292)

* (DOCSP-29548): db.collection.updateSearchIndex method

* add method descriptions to tables

* add new method page to toc

* fix release note wording

* first pass at replacements

* fix replacements

* more replacements

* replacement for drop

* make example runnable

* update replacements

* fix example

* (DOCSP-29549): dropSearchIndex mongosh method (#3307)

* (DOCSP-29549): dropSearchIndex mongosh method

* standardize collections in examples

* (DOCSP-29881): Add Atlas Search db command outputs (#3139) (#3360)

* (DOCSP-29881): Add Atlas Search db command outputs

* wording

* wording

* typo

* wording

* change admonition language to point to listSearchIndexes

* fix stage name

* adjust language for updateSearchIndex response

* edits

* DOCSP-29552: db.collection.getSearchIndexes method page (#3369)

* WIP

* update toc

* final first draft

* fix build errors

* fix replacement

* fix replacement

* fix replacement

* wording

* remove periods

* wording

* typo

* add link

* add missing replacement

* address review comments

* fix build error

* fix build error

* typo

* single source create access control

* fix typo

* single source access control sections

* add name option

* typo

* wording

* wording

* fix section titles

* standardize casing

* DOCSP-29544: $listSearchIndexes aggregation stage (#3382)

* WIP

* WIP

* change file name

* first draft

* add missing ref

* add learn more

* fixups

* fix id type

* remove extra file

* fix id mismatch

* edit

* fix section title

* add lead-in to example subsections

* edits to BUILDING description per Evan

* adjust table widths

* add missing files

* add fts replacement

* (DOCSP-33442): Add new fields to listSearchIndexes output (#4887)

* WIP

* (DOCSP-33442): Add new fields to listSearchIndexes output

* add line breaks to field names

* add more info link for statuses

* edits

* typo

* change examples

* wording

* edits

* standardization

* typo

* wording

* add possible statuses for synonyms

* address review comments

* simplify

* typo

* standardize object vs document

* WIP

* fix build errors

* add table heading

* add synonym detail link

* edit fields

* update examples with real output

* add multi doc example

* add staged index to output

* better pretty printing in output docs

* tweak

* add version-added

* Evan review edits

* formatting

* edits

* add versionadded

* update atlas search nav page

* update dropSearchIndex

* sync from master

* sync from master

* sync from master

* remove references to future versions

* standardize versionadded

* change versionadded text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants