Skip to content

Conversation

bgrabar
Copy link

@bgrabar bgrabar commented Jan 7, 2014

READY for merge! Reviewed and approved.

@tychoish
Copy link
Contributor

tychoish commented Jan 8, 2014

Delivered comments in email. Great start.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arg. is it easy to revert this?

(passive sentence here? includes make it easy to edit. sorry to waffle)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "where the role is created" is OK. But if you want to reword, it'd be quick to do in the few files that use it.
I'm still liking not doing an include for this info because it's unlikely to change.

@bgrabar
Copy link
Author

bgrabar commented Jan 10, 2014

Ready for merge. Reviewed and approved.

@tychoish
Copy link
Contributor

merged. no edits.

still probably want to go back to includes and fix the passive sentence, but I didn't make the change.

@tychoish tychoish closed this Jan 10, 2014
mongo-cr-bot pushed a commit that referenced this pull request Jul 28, 2022
* DOCSP-23926-shard-key-requirement

* DOCSP-23926-shard-key-requirement

* DOCSP-23926-shard-key-requirement

* DOCSP-23926-shard-key-requirement

* DOCSP-23926-shard-key-requirement

Co-authored-by: jason-price-mongodb <[email protected]>
mongo-cr-bot pushed a commit that referenced this pull request Jul 28, 2022
* DOCS-15333-dbhash-locking (#1473)

Co-authored-by: jason-price-mongodb <[email protected]>

* DOCS-15333-dbhash-locking

* DOCS-15333-dbhash-locking

* DOCS-15333-dbhash-locking

* DOCSP-23926 shard key requirement (#1513)

* DOCSP-23926-shard-key-requirement

* DOCSP-23926-shard-key-requirement

* DOCSP-23926-shard-key-requirement

* DOCSP-23926-shard-key-requirement

* DOCSP-23926-shard-key-requirement

Co-authored-by: jason-price-mongodb <[email protected]>

Co-authored-by: jason-price-mongodb <[email protected]>
mongodb-server-docs-sync-bot bot pushed a commit that referenced this pull request Jul 28, 2025
* Switch the order of Ruby and URI option sections

* Note second is the default unit

* Revise timeout options

* Use headings and sections over blockquotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants