Skip to content

Conversation

@osharaf-mdb
Copy link
Contributor

@osharaf-mdb osharaf-mdb commented Jul 19, 2024

Pull Request Info

Jira ticket: https://jira.mongodb.org/browse/DOCSP-41659

Reminder Checklist

Before merging your PR, make sure to check a few things.

  • [N/A] Did you tag pages appropriately?
    • genre
    • programming_language
    • meta.keywords
    • meta.description
  • Describe your PR's changes in the Release Notes section
  • [N/A] Create a Jira ticket for related docs-realm work, if any

Release Notes

  • Node.js SDK
    • Model Data/Data Types/Counters: Fix typos on the Node.js SDK Counters page.

Review Guidelines

REVIEWING.md

@netlify
Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for device-sdk ready!

Name Link
🔨 Latest commit 9bb525a
🔍 Latest deploy log https://app.netlify.com/sites/device-sdk/deploys/669ae0eed477b40008941098
😎 Deploy Preview https://deploy-preview-3332--device-sdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 28 (🔴 down 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 75 (no change from production)
SEO: 69 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Readability for Commit Hash: 9bb525a

You can see any previous Readability scores (if they exist) by looking
at the comment's history.

Readability scores for changed documents:

  • source/sdk/node/model-data/data-types/counters: Grade Level: 8.2, Reading Ease: 58.79

For Grade Level, aim for 8 or below.

For Reading Ease scores, aim for 60 or above:

Score Difficulty
90-100 Very Easy
80-89 Easy
70-79 Fairly Easy
60-69 Medium
50-59 Fairly Hard
30-49 Hard
0-29 Very Hard

For help improving readability, try Hemingway App.

Copy link
Collaborator

@dacharyc dacharyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@osharaf-mdb osharaf-mdb merged commit 16cd3b3 into mongodb:master Jul 22, 2024
@osharaf-mdb osharaf-mdb deleted the DOCSP-41659-nodejs-counters-typo branch July 22, 2024 15:11
@docs-builder-bot
Copy link

docs-builder-bot commented Jul 22, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants