Skip to content

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Dec 15, 2023

Use https for both links and update "manual" to use the canonical docs URL

Use https for both links and update "manual" to use the canonical docs URL
@GromNaN
Copy link
Member

GromNaN commented Dec 15, 2023

I suppose it would have no effect if you merged it on older branches, as the documentation is published only for tags?

@ccho-mongodb
Copy link
Contributor

I suppose it would have no effect if you merged it on older branches, as the documentation is published only for tags?

I think you can backport this to all the other non-legacy version branches on this repo. The older version branches (other than for legacy versions which are read-only on the docs platform) should be publishable.

Co-authored-by: Jérôme Tamarelle <[email protected]>
@jmikola jmikola requested review from ccho-mongodb and removed request for jordan-smith721 April 11, 2024 18:32
@jmikola
Copy link
Member Author

jmikola commented Apr 11, 2024

I think you can backport this to all the other non-legacy version branches on this repo. The older version branches (other than for legacy versions which are read-only on the docs platform) should be publishable.

How would backports be handled? Cherry-pick after merging?

If the docs team is willing to handle that as owners of this repo I'm all for it. IIRC, Snooty is used for 1.16+ so it'd be three branches in addition to master.

@ccho-mongodb
Copy link
Contributor

ccho-mongodb commented Apr 12, 2024

How would backports be handled? Cherry-pick after merging?

If the docs team is willing to handle that as owners of this repo I'm all for it. IIRC, Snooty is used for 1.16+ so it'd be three branches in addition to master.

Sure, happy to backport and deploy this change for you. However, if you find that extlinks are overriding the snooty roles as the possibility was raised in this comment, this PR should probably instead remove the extlinks.

@jmikola
Copy link
Member Author

jmikola commented Apr 12, 2024

@ccho-mongodb: @schmalliso confirmed that conf.py does nothing for Snooty. I'll close this PR, but I think the right call is to remove this file from the v1.16 and newer branches.

@jmikola jmikola closed this Apr 12, 2024
@jmikola jmikola deleted the jmikola-patch-1 branch April 12, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants