Selective Backport DOCSP-25723 (#461) #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit a348602)
ccho-mongodb
approved these changes
Dec 6, 2022
Contributor
ccho-mongodb
left a comment
ccho-mongodb
left a comment
There was a problem hiding this comment.
LGTM, left a suggestion to reduce duplicated info.
| 4.3 of the driver. | ||
| .. important:: | ||
|
|
||
| In this driver version, you cannot specify a mutually recursive type as a |
Contributor
There was a problem hiding this comment.
Suggestion:
This seems like repeated content with the first sentence. I think it could be more straightforward to lead this section with the sentence "You cannot specify a ..." and then have an informational admonition that follows mentioning that you can use mutually recursive types in type parameters in v4.11 and later.
Collaborator
Author
There was a problem hiding this comment.
Agreed that would make things read a bit smoother. Since the other versions (v4-10) have this admonition I'm leaning towards merging as-is for consistency's sake, but I can create a quick cleanup ticket to reword at a later time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit a348602)
Pull Request Info
PR Reviewing Guidelines
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/node/docsworker-xlarge/v4.3/fundamentals/typescript/#mutual-recursion
Self-Review Checklist