Skip to content

Conversation

@ccho-mongodb
Copy link
Contributor

@ccho-mongodb ccho-mongodb commented Nov 10, 2022

Pull Request Info

PR Reviewing Guidelines

No JIRA ticket

This PR fixes the code-block rST indentation which silently failed to apply syntax highlighting for the specified language. While it's beyond expectations to review each file, to verify the syntax highlighting is applied, you'll need to individually inspect each code block with Chrome Tools for the "javascript" (or other) style in the code component:

Screen Shot 2022-11-10 at 12 12 16 AM

Staging:

Quick start

Collations

Specify a Query

Logging

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

It's outside the scope of this ticket, but some documents (e.g., on the Specify a Query page) use JS highlighting, while others (e.g., on the Collation page) use none. Probably good to be consistent with this unless there's a small difference in the examples that I'm not seeing.

@ccho-mongodb
Copy link
Contributor Author

lgtm

It's outside the scope of this ticket, but some documents (e.g., on the Specify a Query page) use JS highlighting, while others (e.g., on the Collation page) use none. Probably good to be consistent with this unless there's a small difference in the examples that I'm not seeing.

@mongoKart
If there are ones that you think should have JS highlighting that are showing JS code and not such as the ones just showing text or output that isn't valid json or JS, could you ticket them?

@ccho-mongodb ccho-mongodb merged commit ce0fa18 into mongodb:master Nov 10, 2022
@ccho-mongodb ccho-mongodb deleted the 110922-fix-code-block-indentation branch November 10, 2022 16:11
ccho-mongodb pushed a commit that referenced this pull request Nov 10, 2022
(cherry picked from commit ce0fa18)
ccho-mongodb pushed a commit that referenced this pull request Nov 10, 2022
(cherry picked from commit ce0fa18)
ccho-mongodb pushed a commit that referenced this pull request Nov 10, 2022
(cherry picked from commit ce0fa18)
ccho-mongodb pushed a commit that referenced this pull request Nov 10, 2022
(cherry picked from commit ce0fa18)
ccho-mongodb pushed a commit that referenced this pull request Nov 10, 2022
(cherry picked from commit ce0fa18)
ccho-mongodb pushed a commit that referenced this pull request Nov 10, 2022
(cherry picked from commit ce0fa18)
ccho-mongodb pushed a commit that referenced this pull request Nov 10, 2022
(cherry picked from commit ce0fa18)
ccho-mongodb pushed a commit that referenced this pull request Nov 10, 2022
(cherry picked from commit ce0fa18)
ccho-mongodb pushed a commit that referenced this pull request Nov 10, 2022
(cherry picked from commit ce0fa18)
ccho-mongodb pushed a commit that referenced this pull request Nov 10, 2022
(cherry picked from commit ce0fa18)
ccho-mongodb pushed a commit that referenced this pull request Nov 10, 2022
(cherry picked from commit ce0fa18)
ccho-mongodb pushed a commit that referenced this pull request Nov 10, 2022
(cherry picked from commit ce0fa18)
ccho-mongodb pushed a commit that referenced this pull request Nov 10, 2022
(cherry picked from commit ce0fa18)
ccho-mongodb pushed a commit that referenced this pull request Nov 10, 2022
(cherry picked from commit ce0fa18)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants