Skip to content

DOCSP-50497 Node.js Aggregation Standardization #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 1, 2025
Merged

DOCSP-50497 Node.js Aggregation Standardization #1168

merged 15 commits into from
Jul 1, 2025

Conversation

mballard-mdb
Copy link
Collaborator

@mballard-mdb mballard-mdb commented Jun 23, 2025 •
edited by github-actions bot
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-50497

Staging Links

  • aggregation/pipeline-stages
  • aggregation

    • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    @mballard-mdb mballard-mdb marked this pull request as draft June 23, 2025 17:43
    @netlify Netlify
    Copy link

    netlify bot commented Jun 23, 2025 •
    edited
    Loading

    ✅ Deploy Preview for docs-node ready!

    Name Link
    🔨 Latest commit bc6bff5
    🔍 Latest deploy log https://app.netlify.com/projects/docs-node/deploys/6863e6ac38fdfe000875aeeb
    😎 Deploy Preview https://deploy-preview-1168--docs-node.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    @docs-builder-bot
    Copy link

    docs-builder-bot commented Jun 23, 2025 •
    edited
    Loading

    🔄 Deploy Preview for docs-node processing

    Item Details
    🔨 Latest Commit b75194c2a90105a3325d94e9f7ae04f00178320e
    😎 Deploy Preview https://deploy-preview-1168--docs-node.netlify.app
    🔍 Build Logs View Logs

    @mballard-mdb mballard-mdb marked this pull request as ready for review June 23, 2025 18:58
    rustagir
    rustagir suggested changes Jun 30, 2025
    View reviewed changes
    Copy link
    Contributor

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    mostly small fixes, great job!

    mballard-mdb and others added 8 commits June 30, 2025 12:00
    @mballard-mdb
    DOCSP-41784 Support for Explicit Resource Management (mongodb#1165)
    8f0f343 
    * DOCSP-41784 add support for explicit resource management note where applicable resources are declared

* DOCSP-41784 fix note
format

* DOCSP-41784 change to tip and move pages around

* DOCSP-41784 reword tip for clarity

* DOCSP-41784 update backport file and move tips to below code examples
    @jordan-smith721 @mballard-mdb
    Add redirect for quick start landing page (mongodb#1171)
    e7a22e5
    @mballard-mdb
    DOCSP-50497 suggestions
    a11226b
    @mballard-mdb
    DOCSP=50497 final changes
    c4f6c02
    @mballard-mdb
    revert "Add redirect for quick start landing page (mongodb#1171)"
    f07410b 
    This reverts commit e7a22e5.

revert commit
    @mballard-mdb
    Revert "DOCSP-41784 Support for Explicit Resource Management (mongodb…
    99cfdd9 
    …#1165)"

This reverts commit 8f0f343.
    @mballard-mdb
    DOCSP-50497 removing commits
    a6e5c27
    @mballard-mdb
    DOCSP-50497 remove capital in aggregate method
    1b44eec
    @mballard-mdb mballard-mdb requested a review from rustagir June 30, 2025 18:46
    rustagir
    rustagir suggested changes Jul 1, 2025
    View reviewed changes
    Copy link
    Contributor

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    few more things! thanks

    @mballard-mdb mballard-mdb requested a review from rustagir July 1, 2025 13:53
    rustagir
    rustagir approved these changes Jul 1, 2025
    View reviewed changes
    Copy link
    Contributor

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    lgtm!

    @mballard-mdb mballard-mdb merged commit 4841edd into mongodb:master Jul 1, 2025
    6 checks passed
    @mballard-mdb mballard-mdb deleted the DOCSP-50497-node-agg-standardization branch July 1, 2025 14:49
    @mballard-mdb mballard-mdb restored the DOCSP-50497-node-agg-standardization branch July 1, 2025 14:50
    mballard-mdb added a commit that referenced this pull request Jul 1, 2025
    @mballard-mdb
    Revert "DOCSP-50497 Node.js Aggregation Standardization (#1168)"
    76021ad 
    This reverts commit 4841edd.
    @mballard-mdb mballard-mdb mentioned this pull request Jul 1, 2025
    Merged
    mballard-mdb added a commit that referenced this pull request Jul 1, 2025
    @mballard-mdb
    Revert "DOCSP-50497 Node.js Aggregation Standardization (#1168)" (#1175)
    1e3dc53 
    This reverts commit 4841edd.
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @rustagir rustagir rustagir approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @mballard-mdb @docs-builder-bot @rustagir @jordan-smith721