Docsp-30873: clarifying filters on builders pg #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - Items that cost $0 to $25 | ||
| - A hotel with amenities that include an indoor swimming pool and free parking | ||
| - A food critic review that mentions "spicy" | ||
| - Items that cost more than $0 but less than $25 |
Collaborator
There was a problem hiding this comment.
Nit: Add a period at the end of each bullet as these are complete sentences.
Suggested change
| - Items that cost more than $0 but less than $25 | |
| - Items that cost more than $0 but less than $25. |
Collaborator
There was a problem hiding this comment.
| Filters are the operations MongoDB uses to limit your results to what | ||
| you want to see. | ||
| Filters are operations used to limit the results of a query based on | ||
| specific conditions. Filters are a helpful tool to locate the |
Collaborator
There was a problem hiding this comment.
Nit: is it specific conditions or "the specified conditions"?
Contributor
Author
There was a problem hiding this comment.
good call! I like that a lot more.
| you want to see. | ||
| Filters are operations used to limit the results of a query based on | ||
| specific conditions. Filters are a helpful tool to locate the | ||
| information needed based on search conditions. |
Collaborator
There was a problem hiding this comment.
Suggested change
| information needed based on search conditions. | |
| Filters are a helpful tool to locate information that matches search conditions in a collection. |
Collaborator
|
✨ Staging URL: https://docs-mongodborg-staging.corp.mongodb.com/kotlin/docsworker-xlarge/master/ 🪵 Logs |
rustagir
pushed a commit
that referenced
this pull request
Jul 14, 2023
# Pull Request Info [PR Reviewing Guidelines](https://github.com/mongodb/docs-java/blob/master/REVIEWING.md) [JIRA](https://jira.mongodb.org/browse/DOCSP-30873) [Staging ](https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/DOCSP-30873-Clarifying-Filters-on-Builders-pg/fundamentals/builders/filters/) ## Self-Review Checklist - [x] Is this free of any warnings or errors in the RST? - [x] Did you run a spell-check? - [x] Did you run a grammar-check? - [x] Are all the links working? There was a suggestion to remove filter usage example, but I think it improves understanding for someone new to filters. Very open to suggestions however! Also my change might be a bit redundant but again I think it makes it clearer for someone who might not understand the jargon. (cherry picked from commit ff57fa1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA
Staging
Self-Review Checklist
There was a suggestion to remove filter usage example, but I think it improves understanding for someone new to filters. Very open to suggestions however! Also my change might be a bit redundant but again I think it makes it clearer for someone who might not understand the jargon.