DOCSP-30943: add bson lib explicitly #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccho-mongodb
approved these changes
Jun 23, 2023
Contributor
ccho-mongodb
left a comment
ccho-mongodb
left a comment
There was a problem hiding this comment.
LGTM, a couple questions and a suggestion.
source/whats-new.txt
Outdated
| .. important:: | ||
|
|
||
| Starting in version 4.10.1 of the {+driver-short+}, you must add | ||
| the ``bson-kotlinx`` library as an explicit dependency for using the |
Contributor
There was a problem hiding this comment.
Suggested change
| the ``bson-kotlinx`` library as an explicit dependency for using the | |
| the ``bson-kotlinx`` library as an explicit dependency to use the |
snooty.toml
Outdated
| logbackVersion = "1.2.11" | ||
| log4j2Version = "2.17.1" | ||
| serializationVersion = "1.5.1" | ||
| bsonVersion = "4.10.0" |
Contributor
There was a problem hiding this comment.
Question: Should the BSON library match the new version 4.10.1 or is it not a matching version?
snooty.toml
Outdated
| driver-short = "Kotlin driver" | ||
| driver-long = "MongoDB Kotlin Driver" | ||
| version = "4.10" | ||
| full-version = "4.10.0" |
Contributor
There was a problem hiding this comment.
Question: Should the full-version be 4.10.1 instead?
rustagir
added a commit
that referenced
this pull request
Jun 26, 2023
# Pull Request Info [PR Reviewing Guidelines](https://github.com/mongodb/docs-java/blob/master/REVIEWING.md) JIRA - https://jira.mongodb.org/browse/DOCSP-30943 Staging - [what's new](https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/DOCSP-30943-v4.10.1-updates/whats-new/#what-s-new-in-4.10) / [serialization page](https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/DOCSP-30943-v4.10.1-updates/fundamentals/data-formats/serialization/#add-kotlin-serialization-to-your-project) ## Self-Review Checklist - [x] Is this free of any warnings or errors in the RST? - [ ] Did you run a spell-check? - [ ] Did you run a grammar-check? - [ ] Are all the links working? (cherry picked from commit c86923f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-30943
Staging - what's new / serialization page
Self-Review Checklist