Skip to content

Conversation

@rustagir
Copy link
Contributor

@rustagir rustagir commented Mar 26, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-48120

Staging Links

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@netlify
Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for docs-csharp ready!

Name Link
🔨 Latest commit 997328d
🔍 Latest deploy log https://app.netlify.com/sites/docs-csharp/deploys/67ebf14ce23b3c000890fc0a
😎 Deploy Preview https://deploy-preview-537--docs-csharp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rustagir rustagir requested a review from rstam March 26, 2025 16:11
Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ quick changes


The ``ElemMatch()`` method has an overload that accepts a single filter
parameter. You can use this overload to perform queries that
include nested ``$elemMatch`` statements.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While true that is not the primary purpose of this overload.

The primary purpose is to let you write ElemMatch queries against the values themselves instead of against a property of the values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the text

@rustagir rustagir force-pushed the DOCSP-48120-elemmatch-overload branch from f1b7741 to 997328d Compare April 1, 2025 13:59
@rustagir rustagir requested a review from rstam April 1, 2025 14:00
Copy link
Collaborator

@rstam rstam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rustagir rustagir merged commit ca969d4 into mongodb:master Apr 3, 2025
6 checks passed
rustagir added a commit that referenced this pull request Apr 3, 2025
* merge upstream

* small fix

* MW PR fixes 1

* RStam tech review

(cherry picked from commit ca969d4)
mongoKart pushed a commit to mongoKart/docs-csharp that referenced this pull request May 16, 2025
* merge upstream

* small fix

* MW PR fixes 1

* RStam tech review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants