DOCSP-48356: skipwhile & takewhile #536
Conversation
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shuangela
left a comment
shuangela
left a comment
There was a problem hiding this comment.
lgtm, one non-blocking suggestion!
source/fundamentals/linq.txt
Outdated
| .. code-block:: csharp | ||
|
|
||
| var query = queryableCollection | ||
| .Select(s => s.Grades.TakeWhile(g => g > 90); |
There was a problem hiding this comment.
If the Grades aren't sorted you might be surprised by the results...
There was a problem hiding this comment.
Thanks for the review! Do you think it would better serve users to show a sort on that array in this example?
source/fundamentals/linq.txt
Outdated
| :copyable: false | ||
|
|
||
| { "name" : "Maura Day", "grades" : [92, 97] } | ||
| { "name" : "Saul Curzon", "grades" : [100, 95, 91] } |
There was a problem hiding this comment.
The results do NOT resemble these documents.
The result is an array of Grades. It might better to say the results are:
[92, 97]
[100, 95, 91]
Though I have no idea if the values are correct because I don't know the test data.
There was a problem hiding this comment.
Thanks! I am going to test this example now that the driver is released. I must have interpreted the test from the source code incorrectly.
There was a problem hiding this comment.
Fixed code and results
source/fundamentals/linq.txt
Outdated
| :copyable: false | ||
|
|
||
| { "name" : "Maura Day", "grades" : [80, 90, 70, 83] } | ||
| { "name" : "Saul Curzon", "grades" : [79, 100, 85, 73] } |
There was a problem hiding this comment.
The results do NOT resemble these documents.
The result is an array of Grades.
There was a problem hiding this comment.
Fixed code and results
source/fundamentals/linq.txt
Outdated
| var query = queryableCollection | ||
| .Select(s => s.Grades.TakeWhile(g => g > 90).ToArray()); | ||
|
|
||
| The results might resemble the following documents: |
There was a problem hiding this comment.
The results look right, but calling them "documents" is not quite right.
Maybe just say "The results might resemble the following:"
source/fundamentals/linq.txt
Outdated
| var query = queryableCollection | ||
| .Select(s => s.Grades.SkipWhile(g => g < 75).ToArray()); | ||
|
|
||
| The results might resemble the following documents: |
There was a problem hiding this comment.
The results look right, but calling them "documents" is not quite right.
Maybe just say "The results might resemble the following:"
rustagir
force-pushed
the
DOCSP-48356-skipwhile-takewhile
branch
from
970d0bd to
867c759
Compare
* DOCSP-48356: skipwhile & takewhile * copyable false * RStam tech review * RStam tech review 2 (cherry picked from commit c2adeca)
* DOCSP-48356: skipwhile & takewhile * copyable false * RStam tech review * RStam tech review 2
3 participants
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-48356
Staging Links
linq guide takewhile | skipwhile | table
whats new
Self-Review Checklist