Skip to content

Conversation

@mongoKart
Copy link
Collaborator

@mongoKart mongoKart commented Mar 12, 2025

Exact property will be backported only back to v3.1.

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45048

Staging Links

  • fundamentals/builders
  • fundamentals/linq
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    @netlify
    Copy link

    netlify bot commented Mar 12, 2025

    Deploy Preview for docs-csharp ready!

    Name Link
    🔨 Latest commit a244df4
    🔍 Latest deploy log https://app.netlify.com/sites/docs-csharp/deploys/67d1ef75bfac370008726833
    😎 Deploy Preview https://deploy-preview-517--docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    **Default**: ``null``

    * - ``IndexName``
    - The index to perform the vector search on.
    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Question for tech reviewer: What index is used if this param is empty?

    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    It defaults to "default".

    Copy link
    Collaborator

    @lindseymoore lindseymoore left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    * - ``queryVector``
    - The encoded vector that will be matched with values from the database.
    Although the data type of this parameter is ``QueryVector``, you can also pass an
    array of floating-point numbers.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    array of floating-point numbers.
    array of ``float`` numbers

    S: Helpful to say the data type explicitly.

    @mongoKart mongoKart requested review from a team and JamesKovacs and removed request for a team March 12, 2025 16:25
    @BorisDog BorisDog requested review from BorisDog and removed request for JamesKovacs March 12, 2025 17:20
    perform the following operations:

    - Performs a vector search on the Atlas Vector Search index of the ``plot_embedding`` field using vector embeddings for the string ``"time travel"``
    - Performs a vector search on the Atlas Vector Search index of the ``plot_embedding``
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    It might be misleading to use plot_embedding here and m => m.Embedding in the code.
    Maybe worth adding the EmbeddedMovie model for clarity.

    **Default**: ``null``

    * - ``IndexName``
    - The index to perform the vector search on.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    It defaults to "default".

    @mongoKart mongoKart requested a review from BorisDog March 12, 2025 19:11
    - The index to perform the vector search on.

    | **Data type**: {+string-data-type+}
    | **Default**: ``"default"``
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Sorry I wasn't entirely clear:
    The default value for the property is null (default "default" might mean that the actual value is "default" if unchanged).
    When IndexName == null, "default" is sent to the server.

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    makes sense. Do you know which index this search is run on if one isn't specified?

    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I don't remember what exactly happens when the string "default" is sent to the server.
    Maybe the default index on the server is called "default".


    The following example shows how to generate a ``$vectorSearch`` stage to search
    the ``plot_embedding`` field using vector embeddings for the string ``"time travel"``:
    the ``plot_embedding`` field by using vector embeddings for the string ``"time travel"``:
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    minor: consider having the same wording as in builders for consistency:

    • Perform a vector search on the Atlas Vector Search index of the plot_embedding field using vector embeddings for the string "time travel"

    • Fetch the Title and Plot fields from documents found in the vector search

    @mongoKart mongoKart requested a review from BorisDog March 12, 2025 20:34
    Copy link
    Collaborator

    @BorisDog BorisDog left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @mongoKart mongoKart merged commit 78c9a0d into mongodb:master Mar 12, 2025
    6 checks passed
    @mongoKart mongoKart deleted the docsp-45048-exact-vector branch March 12, 2025 20:50
    github-actions bot pushed a commit that referenced this pull request Mar 12, 2025
    github-actions bot pushed a commit that referenced this pull request Mar 12, 2025
    mongoKart added a commit that referenced this pull request Mar 12, 2025
    (cherry picked from commit 78c9a0d)
    
    Co-authored-by: Mike Woofter <[email protected]>
    mongoKart added a commit that referenced this pull request Mar 12, 2025
    (cherry picked from commit 78c9a0d)
    
    Co-authored-by: Mike Woofter <[email protected]>
    mongoKart added a commit that referenced this pull request Mar 12, 2025
    mongoKart added a commit that referenced this pull request Mar 12, 2025
    mongoKart added a commit that referenced this pull request Mar 12, 2025
    mongoKart added a commit that referenced this pull request Mar 12, 2025
    mongoKart added a commit that referenced this pull request Mar 12, 2025
    mongoKart added a commit that referenced this pull request Mar 12, 2025
    mongoKart added a commit to mongoKart/docs-csharp that referenced this pull request May 16, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants