-
Notifications
You must be signed in to change notification settings - Fork 26
DOCSP-45048 - Vector search params #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| **Default**: ``null`` | ||
|
|
||
| * - ``IndexName`` | ||
| - The index to perform the vector search on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question for tech reviewer: What index is used if this param is empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It defaults to "default".
lindseymoore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
| * - ``queryVector`` | ||
| - The encoded vector that will be matched with values from the database. | ||
| Although the data type of this parameter is ``QueryVector``, you can also pass an | ||
| array of floating-point numbers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| array of floating-point numbers. | |
| array of ``float`` numbers |
S: Helpful to say the data type explicitly.
source/fundamentals/builders.txt
Outdated
| perform the following operations: | ||
|
|
||
| - Performs a vector search on the Atlas Vector Search index of the ``plot_embedding`` field using vector embeddings for the string ``"time travel"`` | ||
| - Performs a vector search on the Atlas Vector Search index of the ``plot_embedding`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be misleading to use plot_embedding here and m => m.Embedding in the code.
Maybe worth adding the EmbeddedMovie model for clarity.
| **Default**: ``null`` | ||
|
|
||
| * - ``IndexName`` | ||
| - The index to perform the vector search on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It defaults to "default".
| - The index to perform the vector search on. | ||
|
|
||
| | **Data type**: {+string-data-type+} | ||
| | **Default**: ``"default"`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I wasn't entirely clear:
The default value for the property is null (default "default" might mean that the actual value is "default" if unchanged).
When IndexName == null, "default" is sent to the server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense. Do you know which index this search is run on if one isn't specified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember what exactly happens when the string "default" is sent to the server.
Maybe the default index on the server is called "default".
source/fundamentals/linq.txt
Outdated
|
|
||
| The following example shows how to generate a ``$vectorSearch`` stage to search | ||
| the ``plot_embedding`` field using vector embeddings for the string ``"time travel"``: | ||
| the ``plot_embedding`` field by using vector embeddings for the string ``"time travel"``: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: consider having the same wording as in builders for consistency:
Perform a vector search on the Atlas Vector Search index of the plot_embedding field using vector embeddings for the string "time travel"
Fetch the Title and Plot fields from documents found in the vector search
BorisDog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 78c9a0d)
(cherry picked from commit 78c9a0d)
(cherry picked from commit 78c9a0d) Co-authored-by: Mike Woofter <[email protected]>
(cherry picked from commit 78c9a0d) Co-authored-by: Mike Woofter <[email protected]>
(cherry picked from commit 78c9a0d)
(cherry picked from commit 78c9a0d)
(cherry picked from commit 78c9a0d)
(cherry picked from commit 78c9a0d)
(cherry picked from commit 78c9a0d)
(cherry picked from commit 78c9a0d)
Exactproperty will be backported only back to v3.1.Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-45048
Staging Links
Self-Review Checklist