-
Notifications
You must be signed in to change notification settings - Fork 26
DOCSP-45004: Run Command #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for mongodb-docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stephmarie17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few nits ✅
| method. You can specify the type returned by the ``RunCommand()`` and ``RunCommandAsync()`` | ||
| methods by specifying the type parameter. You can use the ``BsonDocument`` type to return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[s] Suggestion for brevity and reducing repetition:
| method. You can specify the type returned by the ``RunCommand()`` and ``RunCommandAsync()`` | |
| methods by specifying the type parameter. You can use the ``BsonDocument`` type to return | |
| method. You can specify the type returned by these methods by specifying the type parameter. You can use the ``BsonDocument`` type to return |
| applies to commands run on replica sets or sharded cluster. | ||
|
|
||
| * - ``operationTime`` | ||
| - The logical time of the operation execution. This field only | ||
| applies to commands run on replica sets or sharded cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[q] Are these meant to be singular on purpose? If not, would update:
| applies to commands run on replica sets or sharded cluster. | |
| * - ``operationTime`` | |
| - The logical time of the operation execution. This field only | |
| applies to commands run on replica sets or sharded cluster. | |
| applies to commands run on replica sets or sharded clusters. | |
| * - ``operationTime`` | |
| - The logical time of the operation execution. This field only | |
| applies to commands run on replica sets or sharded clusters. |
adelinowona
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
(cherry picked from commit e4bcadc)
(cherry picked from commit e4bcadc)
(cherry picked from commit e4bcadc)
(cherry picked from commit e4bcadc)
(cherry picked from commit e4bcadc)
(cherry picked from commit e4bcadc)
(cherry picked from commit e4bcadc)
(cherry picked from commit e4bcadc)
(cherry picked from commit e4bcadc)
(cherry picked from commit e4bcadc)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-45004
Staging Links
Self-Review Checklist