Skip to content

Conversation

@mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Nov 20, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45004

Staging Links

  • fundamentals/databases-collections/run-command
  • fundamentals/database-collection
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    @netlify
    Copy link

    netlify bot commented Nov 20, 2024

    Deploy Preview for mongodb-docs-csharp ready!

    Name Link
    🔨 Latest commit 209c821
    🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-csharp/deploys/673e55ab3fd4df0008f418ae
    😎 Deploy Preview https://deploy-preview-320--mongodb-docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @mcmorisi mcmorisi changed the title DOCSP-45005: Run Command DOCSP-45004: Run Command Nov 20, 2024
    @mcmorisi mcmorisi marked this pull request as ready for review November 20, 2024 16:45
    Copy link
    Collaborator

    @stephmarie17 stephmarie17 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM with a few nits ✅

    Comment on lines 56 to 57
    method. You can specify the type returned by the ``RunCommand()`` and ``RunCommandAsync()``
    methods by specifying the type parameter. You can use the ``BsonDocument`` type to return
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    [s] Suggestion for brevity and reducing repetition:

    Suggested change
    method. You can specify the type returned by the ``RunCommand()`` and ``RunCommandAsync()``
    methods by specifying the type parameter. You can use the ``BsonDocument`` type to return
    method. You can specify the type returned by these methods by specifying the type parameter. You can use the ``BsonDocument`` type to return

    Comment on lines 157 to 161
    applies to commands run on replica sets or sharded cluster.

    * - ``operationTime``
    - The logical time of the operation execution. This field only
    applies to commands run on replica sets or sharded cluster.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    [q] Are these meant to be singular on purpose? If not, would update:

    Suggested change
    applies to commands run on replica sets or sharded cluster.
    * - ``operationTime``
    - The logical time of the operation execution. This field only
    applies to commands run on replica sets or sharded cluster.
    applies to commands run on replica sets or sharded clusters.
    * - ``operationTime``
    - The logical time of the operation execution. This field only
    applies to commands run on replica sets or sharded clusters.

    @mcmorisi mcmorisi requested review from a team and adelinowona and removed request for a team November 20, 2024 21:33
    Copy link

    @adelinowona adelinowona left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    @mcmorisi mcmorisi merged commit e4bcadc into mongodb:master Nov 25, 2024
    6 checks passed
    @mcmorisi mcmorisi deleted the DOCSP-45004-run-command-v2 branch November 25, 2024 21:00
    mcmorisi added a commit that referenced this pull request Nov 25, 2024
    (cherry picked from commit e4bcadc)
    mcmorisi added a commit that referenced this pull request Nov 25, 2024
    (cherry picked from commit e4bcadc)
    mcmorisi added a commit that referenced this pull request Nov 25, 2024
    (cherry picked from commit e4bcadc)
    mcmorisi added a commit that referenced this pull request Nov 25, 2024
    (cherry picked from commit e4bcadc)
    mcmorisi added a commit that referenced this pull request Nov 25, 2024
    (cherry picked from commit e4bcadc)
    mcmorisi added a commit that referenced this pull request Nov 25, 2024
    (cherry picked from commit e4bcadc)
    mcmorisi added a commit that referenced this pull request Nov 25, 2024
    (cherry picked from commit e4bcadc)
    mcmorisi added a commit that referenced this pull request Nov 25, 2024
    (cherry picked from commit e4bcadc)
    mcmorisi added a commit that referenced this pull request Nov 25, 2024
    (cherry picked from commit e4bcadc)
    mcmorisi added a commit that referenced this pull request Nov 25, 2024
    (cherry picked from commit e4bcadc)
    mongoKart pushed a commit to mongoKart/docs-csharp that referenced this pull request May 16, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants