Skip to content

Conversation

@mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Sep 19, 2024

MongoDB compat table was already updated

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-43681

Staging Links

  • whats-new
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Are all the links working?

    @netlify
    Copy link

    netlify bot commented Sep 19, 2024

    Deploy Preview for mongodb-docs-csharp ready!

    Name Link
    🔨 Latest commit 85cc7cd
    🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-csharp/deploys/66ec3968aabe7c000860a7c2
    😎 Deploy Preview https://deploy-preview-234--mongodb-docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @mcmorisi mcmorisi marked this pull request as ready for review September 19, 2024 14:35
    Copy link
    Contributor

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    approving with some suggestions

    Comment on lines 41 to 42
    The 2.29 driver release has been tested against {+mdb-server+} version 8.0 and
    includes the following new features:
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: this phrasing doesn't fully explain whether the version is compatible or partially compatible
    maybe something like this is clearer:

    Suggested change
    The 2.29 driver release has been tested against {+mdb-server+} version 8.0 and
    includes the following new features:
    The 2.29 driver release is fully compatible with {+mdb-server+} version 8.0 and
    includes the following new features:

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    According to the release notes, there are some 8.0 features that aren't compatible. Can update this wording to reflect that.

    Comment on lines 44 to 46
    - Adds support for v2 of the Queryable Encryption range protocol.

    - Adds support for range indexes for Queryable Encryption.
    Copy link
    Contributor

    @mcmorisi mcmorisi merged commit 9aa98c6 into mongodb:master Sep 19, 2024
    @mcmorisi mcmorisi deleted the DOCSP-43666-229 branch September 19, 2024 14:51
    mongoKart pushed a commit to mongoKart/docs-csharp that referenced this pull request May 16, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants