DOCSP-42303: Change username and password copy #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for mongodb-docs-csharp failed. Why did it fail? →
|
norareidy
requested changes
Aug 12, 2024
Collaborator
norareidy
left a comment
norareidy
left a comment
There was a problem hiding this comment.
Left a couple questions!
Comment on lines
222
to
223
| - ``<db_username>``: Your LDAP username | ||
| - ``<db_password>``: Your LDAP password |
Collaborator
There was a problem hiding this comment.
Q: Similar question as above: are these different from the database username and password? If so, I'd remove the <db_> part of the placeholder and just keep as is. If not, I'd change to:
Suggested change
| - ``<db_username>``: Your LDAP username | |
| - ``<db_password>``: Your LDAP password | |
| - ``<db_username>``: Your database username | |
| - ``<db_password>``: Your database password |
Collaborator
Author
There was a problem hiding this comment.
Can revert both this and the other comment since it sounds like it's separate.
Comment on lines
54
to
55
| - ``<db_username>``: Your :wikipedia:`URL-encoded <Percent-encoding>` principal name; for example "username%40REALM.ME" | ||
| - ``<db_password>``: Your Kerberos user's password |
Collaborator
There was a problem hiding this comment.
Q: is the "principle name" different from the database username? and is the "Kerberos user's password" different from the database user's password?
mcmorisi
added a commit
that referenced
this pull request
Aug 12, 2024
(cherry picked from commit 167830c)
mcmorisi
added a commit
that referenced
this pull request
Aug 12, 2024
(cherry picked from commit 167830c)
mcmorisi
added a commit
that referenced
this pull request
Aug 12, 2024
(cherry picked from commit 167830c)
mcmorisi
added a commit
that referenced
this pull request
Aug 12, 2024
(cherry picked from commit 167830c)
mcmorisi
added a commit
that referenced
this pull request
Aug 12, 2024
(cherry picked from commit 167830c)
mcmorisi
added a commit
that referenced
this pull request
Aug 12, 2024
(cherry picked from commit 167830c)
mcmorisi
added a commit
that referenced
this pull request
Aug 12, 2024
(cherry picked from commit 167830c)
mcmorisi
added a commit
that referenced
this pull request
Aug 12, 2024
(cherry picked from commit 167830c)
mcmorisi
added a commit
that referenced
this pull request
Aug 12, 2024
(cherry picked from commit 167830c)
mcmorisi
added a commit
that referenced
this pull request
Aug 12, 2024
(cherry picked from commit 167830c)
mongoKart
pushed a commit
to mongoKart/docs-csharp
that referenced
this pull request
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-42375
Staging - https://preview-mongodbmcmorisi.gatsbyjs.io/csharp/DOCSP-42303-username-password/
Self-Review Checklist