Add feature-gated support for casting unsigned integers to signed integers #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with arbitrary inputs such as those from
serde_json::Value
, making use of the existing backwards compatibility APIs can be difficult or impossible. This PR introduces the ability to cast unsigned integers toi32
using the nightlytry_from
API. It exposes this behind an opt-in feature and doesn't make any backwards-incompatible changes.If you'd rather avoid this conversion strategy and stick to strict type checking, that's fine; I'm making use of these for my own project and understand if you'll want to keep them out of upstream.
I also changed all instances of
try!()
to?
.