Skip to content

RUST-1748 Add serde_conv macro for object_id::AsHexString and object_id::FromHexString #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Jul 7, 2025
Merged

RUST-1748 Add serde_conv macro for object_id::AsHexString and object_id::FromHexString #566

merged 30 commits into from
Jul 7, 2025

Conversation

JamieTsai1024
Copy link
Contributor

@JamieTsai1024 JamieTsai1024 commented Jul 3, 2025 •
edited
Loading

  • Add custom serde_conv macro, my_serde_conv, to:
    1. Support rustdoc documentation for structs
    2. Support serializers that may fail by wrapping the return type for serialize in a Result
      • Original implementation assumes that serialization cannot fail, which is not the case for many of our converters. For example, serializing a String to ObjectId may fail in object_id::FromHexString.
  • Refactor full struct (de)serialize_as implementations to use my_serde_conv macro
    • object_id::AsHexString
    • object_id::FromHexString

@JamieTsai1024
Convert to serde_with helpers for ObjectId and DateTime to String
379ac68
@JamieTsai1024
Update tests
5ecd554
@JamieTsai1024
Update rustdoc
4d6dddf
@JamieTsai1024
Fix typo
f4c4d8d
@JamieTsai1024
Update tests for optional and vector struct fields
b408e0d
@JamieTsai1024
Add serde_with converter for Chrono to BSON DateTime
32c6e39
@JamieTsai1024
Put new implementations behind feature flag, add additional tests for…
ba9ae6f 
… optional fields
@JamieTsai1024
Fix imports
09689f4
@JamieTsai1024
Fix lint
832d582
@JamieTsai1024
Remove clone
e351243
@JamieTsai1024
Update imports for documentation
35af075
@JamieTsai1024
Fix clippy and rustdoc
092c270
@JamieTsai1024
Merge branch 'main' into RUST-1748
94a489f
@JamieTsai1024
Add serde as a dependency for serde_with-3
b69b21a
@JamieTsai1024
Simplify documentation import
6193860
@JamieTsai1024
Refactor: Use serde_conv for String to/from ObjectId conversion in st…
087e6e2 
…ruct implementation
@JamieTsai1024
Support falliable serialization in my_serde_conv
edbc1a2
@JamieTsai1024
Add hex string to error log
e3c351f
@JamieTsai1024
Add error path tests for string conversions
d6d9de6
@JamieTsai1024
Remove tests for empty optional fields with skip_serializing_if
f1d8d50
@JamieTsai1024
Remove optional converter for Chrono and BSON DateTime
f4a8857
@JamieTsai1024
Simplify module and struct names for better ergonomics
11568ac
@JamieTsai1024
Refactor serialized vector tests
e26879e
@JamieTsai1024
Remove default feature flags
68fefb4
@JamieTsai1024
Update import in readme
d59c7d5
@JamieTsai1024
Merge branch 'RUST-1748' into RUST-1748-serde_conv
bde73b5
@JamieTsai1024
Merge branch 'main' into RUST-1748-serde_conv
59cec75
@JamieTsai1024 JamieTsai1024 marked this pull request as ready for review July 3, 2025 15:29
@JamieTsai1024 JamieTsai1024 requested a review from a team as a code owner July 3, 2025 15:29
@JamieTsai1024 JamieTsai1024 requested a review from abr-egn July 3, 2025 15:29
@isabelatkinson isabelatkinson removed the request for review from abr-egn July 3, 2025 15:43
abr-egn
abr-egn reviewed Jul 3, 2025
View reviewed changes
@JamieTsai1024 JamieTsai1024 requested a review from abr-egn July 3, 2025 18:33
abr-egn
abr-egn approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@abr-egn abr-egn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JamieTsai1024 JamieTsai1024 merged commit 7703fee into mongodb:main Jul 7, 2025
9 of 11 checks passed
@JamieTsai1024 JamieTsai1024 mentioned this pull request Jul 8, 2025
Merged
@JamieTsai1024 JamieTsai1024 changed the title Rust 1748 Add serde_conv macro for object_id::AsHexString and object_id::FromHexString RUST-1748 Add serde_conv macro for object_id::AsHexString and object_id::FromHexString Jul 8, 2025
This was referenced Jul 11, 2025
Closed
Closed
Closed
Merged
This was referenced Jul 21, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abr-egn abr-egn abr-egn approved these changes

@isabelatkinson isabelatkinson Awaiting requested review from isabelatkinson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JamieTsai1024 @abr-egn