RUST-782 Add hyperlinks for all types in rustdoc #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
requested review from
a team and
kmahar
and removed request for
a team
kmahar
reviewed
Jan 3, 2023
| //! instead of the `uuid` crate's `Uuid`, since [`crate::Uuid`] correctly produces subtype 4 binary | ||
| //! values via either serialization function. | ||
| //! instead of the `uuid` crate's [`Uuid`], since [`crate::Uuid`] correctly produces subtype 4 | ||
| //! binary values via either serialization function. |
There was a problem hiding this comment.
here and elsewhere in these docs is it worth linking to the corresponding BinarySubtype cases rather than just mentioning subtypes numbers, e.g. BinarySubtype::Generic and BinarySubtype::Uuid?
There was a problem hiding this comment.
I agree that's a reasonable idea, it looks like there's a bunch of places that could use that update so I filed RUST-1561 for that.
kmahar
approved these changes
Jan 3, 2023
patrickfreed
approved these changes
Jan 4, 2023
isabelatkinson
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.