Skip to content

RUST-942 Properly generate 5 random bytes instead of 3 for ObjectIds (1.2.x) #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2021
Merged

RUST-942 Properly generate 5 random bytes instead of 3 for ObjectIds (1.2.x) #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions src/oid.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ impl ObjectId {
hex::encode(self.id)
}

// Generates a new timestamp representing the current seconds since epoch.
// Represented in Big Endian.
/// Generates a new timestamp representing the current seconds since epoch.
/// Represented in Big Endian.
fn gen_timestamp() -> [u8; 4] {
let timestamp: u32 = SystemTime::now()
.duration_since(SystemTime::UNIX_EPOCH)
Expand All @@ -160,22 +160,17 @@ impl ObjectId {
timestamp.to_be_bytes()
}

// Generate a random 5-byte array.
/// Generate a random 5-byte array.
fn gen_process_id() -> [u8; 5] {
lazy_static! {
static ref BUF: [u8; 5] = {
let rng = thread_rng().gen_range(0, MAX_U24) as u32;
let mut buf: [u8; 5] = [0; 5];
buf[0..4].copy_from_slice(&rng.to_be_bytes());
buf
};
static ref BUF: [u8; 5] = thread_rng().gen();
}

*BUF
}

// Gets an incremental 3-byte count.
// Represented in Big Endian.
/// Gets an incremental 3-byte count.
/// Represented in Big Endian.
fn gen_count() -> [u8; 3] {
let u_counter = OID_COUNTER.fetch_add(1, Ordering::SeqCst);

Expand Down