RUST-882 Fix lossy From<u32> Bson impl, prevent overflow in From<u64> (1.2.x)
#281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
commented
Jul 22, 2021
| /// Note: due to https://github.com/rust-lang/rust/issues/39935 we cannot deprecate this implementation. | ||
| fn from(a: u64) -> Bson { | ||
| Bson::Int64(a as i64) | ||
| Bson::Int64(a.try_into().unwrap_or(i64::MAX)) |
There was a problem hiding this comment.
for lack of a better option, I tried to make this "less bad", but short of panicking I'm not sure we have any other choice. I'm hesitant to panic given that we can't even deprecate this impl though.
There was a problem hiding this comment.
Agreed that this is the less-bad option.
abr-egn
approved these changes
Jul 23, 2021
| /// Note: due to https://github.com/rust-lang/rust/issues/39935 we cannot deprecate this implementation. | ||
| fn from(a: u64) -> Bson { | ||
| Bson::Int64(a as i64) | ||
| Bson::Int64(a.try_into().unwrap_or(i64::MAX)) |
There was a problem hiding this comment.
Agreed that this is the less-bad option.
isabelatkinson
approved these changes
Jul 23, 2021
patrickfreed
force-pushed
the
RUST-882/fix-lossy-1.2.x
branch
from
74f8dbf to
21b5ec5
Compare
patrickfreed
added a commit
that referenced
this pull request
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-882
This is the
1.2.xbackport fix of RUST-882.