add wasm support #111
Closed
add wasm support #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kyeah Please review these commits. |
|
It's worth noting that MongoDB drivers as a whole are moving towards implementations independent of the hostname and PID, as described here. It might be worth just updating the implementation to follow that spec, which both saves us from needing to use conditional compilation (as the implementation would work for both standard Rust and wasm) and would bring us in line with what other drivers are doing. |
|
Thanks @saghm ! If everyone is okay with using just the random bytes and having one compilation, I will gladly change this PR to accommodate that. |
4 tasks
|
@kyeah not delayed at all, don't worry! let me fix this PR to just have the one compilation that uses random bytes. |
|
closing in favour of #114 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I am using this module in a library that will be compiled to WASM. The current version doesn't quite work, as it makes system calls (
get_hostname()andlibc::getpid()specifically).You can try this yourself with
cargo build --target wasm32-unknown-unknown.This PR adds two replacement functions that will only be used in case of WASM, and in all other cases the current implementation will stay. The WASM-compatible functions just generate random numbers for machine id and process id; it's done similarly in the js version of bson.
Thank you for reviewing o/ !