chore(cli-repl): account for changes to nightly driver typings #2556
Conversation
Specifically, match the stricter typing in mongodb/node-mongodb-native@dab4c7c.
There was a problem hiding this comment.
Pull Request Overview
This PR updates TypeScript type definitions in the crypt library paths module to align with stricter typing requirements from the nightly MongoDB Node.js driver. The changes introduce template literal types to ensure type safety for shared library paths and their suffixes.
Key changes:
- Added
SharedObjectSuffixtype to restrict valid shared library file extensions - Applied template literal types to
cryptSharedLibPathand library candidate paths to enforce naming patterns
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| export interface CryptLibraryPathResult { | ||
| cryptSharedLibPath?: string; | ||
| cryptSharedLibPath?: `${string}mongo_crypt_v${number}.${SharedObjectSuffix}`; |
There was a problem hiding this comment.
The template literal type requires 'mongo_crypt_v' but the actual library paths use 'mongosh_crypt_v1' (as seen in line 57). This mismatch will cause type errors since the actual paths don't match the pattern 'mongo_crypt_v${number}'.
| cryptSharedLibPath?: `${string}mongo_crypt_v${number}.${SharedObjectSuffix}`; | |
| cryptSharedLibPath?: `${string}mongosh_crypt_v${number}.${SharedObjectSuffix}`; |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
These are correct concerns, but we intentionally rename this file to avoid conflicts with a potentially user-installed file of that name
addaleax
added
the
no-title-validation
2 participants
Specifically, match the stricter typing in mongodb/node-mongodb-native@dab4c7c.