chore(ci): push mongosh tag separately during release #2508
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the package publishing process to push the mongosh tag separately during release to ensure GitHub Actions workflow triggers work correctly. GitHub Actions has a limitation where create tag workflows only run when 3 or fewer tags are created simultaneously.
- Adds separate git push command for mongosh tag to bypass GitHub Actions tag creation limit
- Includes conditional logic to skip this operation during dry runs
- Documents the GitHub Actions limitation with inline comments
| @@ -111,6 +111,17 @@ export class PackagePublisher { | |||
| if (!mongoshVersion) { | |||
| throw new Error('mongosh package not found'); | |||
| } | |||
|
|
|||
| if (mongoshVersion && !this.config.isDryRun) { | |||
There was a problem hiding this comment.
The condition mongoshVersion && !this.config.isDryRun is redundant since mongoshVersion was already validated on line 111-113 with an error thrown if it's falsy. The condition can be simplified to just if (!this.config.isDryRun).
Suggested change
| if (mongoshVersion && !this.config.isDryRun) { | |
| if (!this.config.isDryRun) { |
Copilot uses AI. Check for mistakes.
addaleax
approved these changes
Jul 21, 2025
Since GitHub Actions only runs create tag workflows when no more than 3 tags are created (https://docs.github.com/en/actions/reference/events-that-trigger-workflows#create), we will push the mongosh tag separately to ensure it triggers the merge tag workflow
gagik
force-pushed
the
gagik/mongosh-test
branch
from
1e97975 to
b4fd81b
Compare
gagik
added
the
no-title-validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since GitHub Actions only runs create tag workflows when no more than 3 tags are created (https://docs.github.com/en/actions/reference/events-that-trigger-workflows#create), we will push the mongosh tag separately to ensure it triggers the merge tag workflow