chore: use describeWithMongoDB to setup test suites instead of custom wiring #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the describeWithMongoDB helper function interface to accept a configuration object instead of individual parameters, and adds support for elicitation-related options. The change improves maintainability as the number of parameters was increasing.
Key changes:
- Refactored
describeWithMongoDBto accept aTestSuiteConfigobject instead of separate function parameters - Added elicitation support with
getMockElicitationInputandgetClientCapabilitiesoptions - Updated all test files to use the new interface with
defaultTestSuiteConfigas the base configuration
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/integration/tools/mongodb/mongodbHelpers.ts |
Defines new TestSuiteConfig interface and updates describeWithMongoDB function signature |
tests/integration/elicitation.test.ts |
Converts elicitation tests to use describeWithMongoDB with new elicitation options |
| Multiple test files (search, read, connect, etc.) | Updates all existing describeWithMongoDB calls to use new object-based configuration |
himanshusinghs
changed the title
himanshusinghs
added
the
no-title-validation
The number of parameters were increasing as I wanted to add elicitInput as another argument. This commit compacts the rest of the config parameters in an object and modifies the usage to call the method correctly. Additionally, in places where we were just doing the defaults, this commit modifies those calls to not pass anything and rely on default.
Additionally modifies elicitation tests to use describeWithMongoDB
himanshusinghs
force-pushed
the
chore/tests-helper-refactor
branch
from
d8fea3a to
475ea09
Compare
nirinchev
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In some places we were doing the same wiring as the one that is already done in
describeWithMongoDBand the reason for that was we needed some extra configuration to be passed down tosetupIntegrationTestor tosetupMongoDBIntegrationTest. This PR modifiesdescribeWithMongoDBto accept the additional parameters and pass them down tosetupIntegrationTestandsetupMongoDBIntegrationTestand unify the usage in tests to usedescribeWithMongoDBinstead of manual wiring.The motivation is to have one place to have checks like skipping test on specific environments.
Notes for reviewers
Review individual commits.
Checklist