fix: cleanup script should group errors #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the cleanup script's error handling by ensuring it attempts to clean up as many resources as possible before reporting failures. Instead of stopping on the first error, the script now collects all errors and reports them at the end.
Key changes:
- Modified error handling to collect errors rather than fail immediately
- Enhanced cluster deletion to return error information instead of throwing
- Added comprehensive error reporting at the end of the cleanup process
Comment on lines
+117
to
+118
| const errorStr = String(error); | ||
| const errorMessage = `Failed to delete project ${project.name} (${project.id}): ${errorStr}`; |
There was a problem hiding this comment.
Consider extracting the error message formatting into a helper function since similar patterns are used in lines 63 and 67. This would reduce code duplication and improve consistency.
Copilot uses AI. Check for mistakes.
jeroenvervaeke
approved these changes
Oct 14, 2025
himanshusinghs
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist