feat: add ability to create vector search indexes MCP-234 MCP-243 #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Pull Request Test Coverage Report for Build 18482155309Details
💛 - Coveralls |
nirinchev
force-pushed
the
ni/create-vector-index
branch
from
4113579 to
69aa6d0
Compare
This comment has been minimized.
This comment has been minimized.
📊 Accuracy Test Results📈 Summary
📊 Baseline Comparison
📎 Download Full HTML Report - Look for the Report generated on: 10/14/2025, 10:36:40 AM |
There was a problem hiding this comment.
Pull Request Overview
This PR adds vector search index creation capability to the existing create-index tool, allowing users to create both classic MongoDB indexes and vector search indexes through the MCP server.
- Extends the
create-indextool to support vector search indexes alongside existing classic indexes - Refactors the tool's API to use a definition array with discriminated union types for different index types
- Adds comprehensive test coverage for the new vector search functionality
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/tools/mongodb/create/createIndex.ts |
Core implementation adding vector search index support with feature flag gating |
src/tools/tool.ts |
Adds feature flag infrastructure for vector search functionality |
tests/integration/tools/mongodb/create/createIndex.test.ts |
Extensive test coverage for both classic and vector search index creation |
tests/integration/tools/mongodb/mongodbHelpers.ts |
Moves shared search helper functions from individual test files |
tests/integration/tools/mongodb/search/listSearchIndexes.test.ts |
Refactors to use centralized helper functions |
tests/integration/helpers.ts |
Updates parameter validation to handle discriminated union schemas |
tests/accuracy/createIndex.test.ts |
Updates accuracy tests with new API and adds vector search test cases |
tests/accuracy/dropIndex.test.ts |
Updates to use new definition array format |
tests/accuracy/sdk/describeAccuracyTests.ts |
Adds voyage API key parameter support |
tests/accuracy/sdk/accuracyTestingClient.ts |
Adds voyage API key to client initialization |
kmruiz
reviewed
Oct 15, 2025
| const isVectorSearchSupported = await this.session.isConnectedToMongot; | ||
| if (!isVectorSearchSupported) { | ||
| // TODO: remove hacky casts once we merge the local dev tools | ||
| const isLocalAtlasAvailable = |
There was a problem hiding this comment.
We are checking if a tool exists in a few places already in other places, maybe we can extract this to a function and refactor?
kmruiz
reviewed
Oct 15, 2025
kmruiz
reviewed
Oct 15, 2025
kmruiz
approved these changes
Oct 15, 2025
nirinchev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This adds the ability to create a vector search index to the
create-indextool. This is a consolidated tool that's using a discriminated union definition when deciding what type of index to create.For the initial release, we're feature-flagging the search capabilities, so only adding the vector search option to the union in case the feature flag is enabled, but that will be dropped in the future. We're not updating the definition regardless of whether we're connected to atlas search capable server or not.