chore: validate apiBaseUrl #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds client-side validation to ensure the Atlas API base URL uses HTTPS before attempting to validate credentials with the MongoDB Atlas API.
- Adds HTTPS validation for
apiBaseUrlin the server initialization process - Throws an error with a descriptive message if the URL doesn't start with "https://"
- Provides early validation before making actual API calls to Atlas
src/server.ts
Outdated
| try { | ||
| if (!this.userConfig.apiBaseUrl.startsWith("https://")) { | ||
| const message = | ||
| "Failed to validate MongoDB Atlas the credentials from the config: API URL must be HTTPS"; |
There was a problem hiding this comment.
Grammar error in the error message. Remove 'the' before 'credentials' to fix: 'Failed to validate MongoDB Atlas credentials from the config: API URL must be HTTPS'
Copilot uses AI. Check for mistakes.
kmruiz
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adding an extra validation even though Atlas API already validates this.
Checklist