Skip to content

Conversation

@himanshusinghs
Copy link
Collaborator

@himanshusinghs himanshusinghs commented Sep 16, 2025

Proposed changes

The idea is to have all (excpect object properties because we cannot parse them yey) the MCP config in the OPTIONS object so that the verification method can look up the config being provided and if its valid or not.

Checklist

The idea is to have all the MCP config in the OPTIONS object so that the
verification method can look up the config being provided and if its
valid or not.
@himanshusinghs himanshusinghs requested a review from a team as a code owner September 16, 2025 13:49
Copilot AI review requested due to automatic review settings September 16, 2025 13:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds missing configuration properties to the MCP (MongoDB Compass Protocol) configuration object to enable proper validation. The changes ensure that all config properties are properly categorized by type so the verification method can validate them.

  • Adds three new string configuration properties for export functionality
  • Adds a new array configuration property for confirmation-required tools
  • Introduces a new object configuration type with httpHeaders property

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@coveralls
Copy link
Collaborator

coveralls commented Sep 16, 2025

Pull Request Test Coverage Report for Build 17768408252

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.068%

Totals Coverage Status
Change from base Build 17766022256: 0.0%
Covered Lines: 5023
Relevant Lines: 6009

💛 - Coveralls

@himanshusinghs himanshusinghs merged commit d432be1 into main Sep 16, 2025
22 of 24 checks passed
@himanshusinghs himanshusinghs deleted the chore/fix-config-verification branch September 16, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants