Skip to content

Conversation

himanshusinghs
Copy link
Collaborator

Proposed changes

The earlier script was not for bash, maybe for windows CMD / Powershell (based on the usage of Write-Output command) so I translated the script to bash in this PR.

Checklist

@Copilot Copilot AI review requested due to automatic review settings September 10, 2025 11:31
@himanshusinghs himanshusinghs requested a review from a team as a code owner September 10, 2025 11:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR converts a PowerShell script to bash for detecting release channels from version strings in a GitHub Actions workflow. The script parses version strings to extract release channel information (latest, alpha, beta, rc) for npm publishing.

  • Converts PowerShell regex and string operations to equivalent bash functionality
  • Adds explicit shell specification and proper environment variable handling
  • Maintains the same logic for extracting release channels from version strings

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@coveralls
Copy link
Collaborator

coveralls commented Sep 10, 2025

Pull Request Test Coverage Report for Build 17613684857

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 81.29%

Totals Coverage Status
Change from base Build 17613001615: 0.003%
Covered Lines: 4769
Relevant Lines: 5772

💛 - Coveralls

Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

@himanshusinghs himanshusinghs force-pushed the fix/pre-release-workflow branch from 9ae5727 to 93dad7b Compare September 10, 2025 12:26
Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the updates

@himanshusinghs himanshusinghs merged commit 67bdaaa into main Sep 10, 2025
18 checks passed
@himanshusinghs himanshusinghs deleted the fix/pre-release-workflow branch September 10, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants