-
Notifications
You must be signed in to change notification settings - Fork 129
chore: fix release channel detection script #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR converts a PowerShell script to bash for detecting release channels from version strings in a GitHub Actions workflow. The script parses version strings to extract release channel information (latest, alpha, beta, rc) for npm publishing.
- Converts PowerShell regex and string operations to equivalent bash functionality
- Adds explicit shell specification and proper environment variable handling
- Maintains the same logic for extracting release channels from version strings
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Pull Request Test Coverage Report for Build 17613684857Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment
9ae5727
to
93dad7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the updates
Proposed changes
The earlier script was not for bash, maybe for windows CMD / Powershell (based on the usage of Write-Output command) so I translated the script to bash in this PR.
Checklist