Skip to content

chore: fix flakiness of exports by waiting to at least have 1 available #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

chore: fix flakiness of exports by waiting to at least have 1 available #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/exportsManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ type StoredExport = ReadyExport | InProgressExport;
*
* Ref Cursor: https://forum.cursor.com/t/cursor-mcp-resource-feature-support/50987
* JIRA: https://jira.mongodb.org/browse/MCP-104 */
type AvailableExport = Pick<StoredExport, "exportName" | "exportTitle" | "exportURI" | "exportPath">;
export type AvailableExport = Pick<StoredExport, "exportName" | "exportTitle" | "exportURI" | "exportPath">;

export type ExportsManagerConfig = Pick<UserConfig, "exportsPath" | "exportTimeoutMs" | "exportCleanupIntervalMs">;

Expand Down
18 changes: 14 additions & 4 deletions tests/unit/common/exportsManager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
ExportsManager,
validateExportName,
} from "../../../src/common/exportsManager.js";

import type { AvailableExport } from "../../../src/common/exportsManager.js";
import { config } from "../../../src/common/config.js";
import { ROOT_DIR } from "../../accuracy/sdk/constants.js";
import { timeout } from "../../integration/helpers.js";
Expand Down Expand Up @@ -124,6 +124,15 @@ function timeoutPromise(timeoutMS: number, context: string): Promise<never> {
});
}

async function waitUntilThereIsAnExportAvailable(manager: ExportsManager): Promise<AvailableExport[]> {
return await vi.waitFor(() => {
const exports = manager.availableExports;
expect(exports.length).toBeGreaterThan(0);

return exports;
});
}

async function getExportAvailableNotifier(
expectedExportURI: string,
manager: ExportsManager,
Expand Down Expand Up @@ -318,7 +327,8 @@ describe("ExportsManager unit test", () => {
await cursorCloseNotification;

// Updates available export
const availableExports = manager.availableExports;
// this is async code so we should wait and retry
const availableExports = await waitUntilThereIsAnExportAvailable(manager);
expect(availableExports).toHaveLength(1);
expect(availableExports).toContainEqual(
expect.objectContaining({
Expand Down Expand Up @@ -352,7 +362,7 @@ describe("ExportsManager unit test", () => {

const expectedExportName = exportName.endsWith(".json") ? exportName : `${exportName}.json`;
// Updates available export
const availableExports = manager.availableExports;
const availableExports = await waitUntilThereIsAnExportAvailable(manager);
expect(availableExports).toHaveLength(1);
expect(availableExports).toContainEqual(
expect.objectContaining({
Expand Down Expand Up @@ -387,7 +397,7 @@ describe("ExportsManager unit test", () => {

const expectedExportName = exportName.endsWith(".json") ? exportName : `${exportName}.json`;
// Updates available export
const availableExports = manager.availableExports;
const availableExports = await waitUntilThereIsAnExportAvailable(manager);
expect(availableExports).toHaveLength(1);
expect(availableExports).toContainEqual(
expect.objectContaining({
Expand Down
Loading