Skip to content

Conversation

kmruiz
Copy link
Collaborator

@kmruiz kmruiz commented Sep 4, 2025

Proposed changes

Checklist

@kmruiz kmruiz self-assigned this Sep 4, 2025
@Copilot Copilot AI review requested due to automatic review settings September 4, 2025 11:07
@kmruiz kmruiz added the no-title-validation Add this label to disable the title check for this PR. label Sep 4, 2025
@kmruiz kmruiz requested a review from a team as a code owner September 4, 2025 11:07
@coveralls
Copy link
Collaborator

coveralls commented Sep 4, 2025

Pull Request Test Coverage Report for Build 17462811148

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 81.158%

Totals Coverage Status
Change from base Build 17462619246: -0.006%
Covered Lines: 4660
Relevant Lines: 5654

💛 - Coveralls

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes TypeScript typing issues for the mongodb-connection-string-url package by updating import statements and adding path mapping configuration.

  • Changes default imports to named imports for the ConnectionString class
  • Adds TypeScript path mapping to resolve the correct type definitions

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
tsconfig.build.json Adds path mapping to resolve mongodb-connection-string-url type definitions
src/helpers/connectionOptions.ts Updates import from default to named import for ConnectionString
src/common/connectionManager.ts Updates import from default to named import for ConnectionString

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kmruiz kmruiz merged commit 6bfaad4 into main Sep 4, 2025
20 of 22 checks passed
@kmruiz kmruiz deleted the fix/typings branch September 4, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-title-validation Add this label to disable the title check for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants