-
Notifications
You must be signed in to change notification settings - Fork 130
fix: start mcp even if connection fails - [MCP-140] #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
id: LogId.serverInitialized, | ||
context: "server", | ||
message: `Server started with transport ${transport.constructor.name} and agent runner ${this.session.mcpClient?.name}`, | ||
message: `Server with version ${packageInfo.version} started with transport ${transport.constructor.name} and agent runner ${JSON.stringify(this.session.mcpClient)}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding more logs to make it easier to debug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the MCP server to allow it to start successfully even when the initial MongoDB connection fails. Previously, connection failures would prevent the server from starting.
- Removes error throwing when MongoDB connection fails during server initialization
- Adds informational and error logging for connection attempts
- Enhances server startup logging with version and client information
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Pull Request Test Coverage Report for Build 17402691381Details
💛 - Coveralls |
* main: feat: add more details about atlas connect flow - MCP-124 (#500) chore: extend library interfaces to allow injecting a custom connection error handler MCP-132 (#502) fix: start mcp even if connection fails - [MCP-140] (#503) fix: allow connect tool on readOnly mode (#499) chore: warn about the usage of deprecated cli arguments MCP-107 (#493) ci: add ipAccessList after creating project (#496)
Proposed changes
MCP-140
Tests
Logs for a successfull flow
Logs for a failed flow
Checklist